Skip to content
This repository has been archived by the owner on Jan 16, 2018. It is now read-only.

Duplicate results in Performance mode #67

Open
Olie440 opened this issue May 10, 2017 · 1 comment
Open

Duplicate results in Performance mode #67

Olie440 opened this issue May 10, 2017 · 1 comment

Comments

@Olie440
Copy link

Olie440 commented May 10, 2017

When performance mode is turned on and the definition is in an open file atom shows the same result twice:
image

Looking into it it appears to be caused by ripgrep not ignoring absolute paths:
image

I have fixed this locally by removing the atom buffer scan, and am happy to make a PR.
However this has the side effect of excluding files outside the project. Although that would be an edge case I thought I raise it anyway.

I have also raised this issue on the ripgrep repo:
BurntSushi/ripgrep#479

@jbazin30
Copy link

jbazin30 commented Nov 8, 2017

Hello,
I am interested in knowing how to remove the atom buffer scan.
I'm novice with packaging edition in Atom.

Thx

Edit :

Based on your issue BurntSushi/ripgrep#479 it's work with this :
return filePath.split("/").pop(); on line 56 in ~/.atom/packages/goto-definition/lib/searcher.js

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants