Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Scala rules override javac args, do not allow extra scalac args #1898

Open
dsilvasc opened this issue May 24, 2018 · 0 comments
Open

Scala rules override javac args, do not allow extra scalac args #1898

dsilvasc opened this issue May 24, 2018 · 0 comments
Labels
P3 Priority 3

Comments

@dsilvasc
Copy link

Note how Kotlin and Groovy rules both have extra args for their compilers -- getExtraKotlincArguments and getExtraGroovycArguments:
https://github.com/facebook/buck/blob/master/src/com/facebook/buck/jvm/kotlin/KotlinLibraryDescription.java#L164
https://github.com/facebook/buck/blob/master/src/com/facebook/buck/jvm/groovy/GroovyLibraryDescription.java#L97

The Scala rules don't have that, and they override the javac extra args:
https://github.com/facebook/buck/blob/master/src/com/facebook/buck/jvm/scala/ScalaLibraryDescription.java#L178

This leads to uber/okbuck#645 and uber/okbuck#644

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 Priority 3
Projects
None yet
Development

No branches or pull requests

2 participants