{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":540915415,"defaultBranch":"main","name":"buck2-prelude","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-09-24T17:42:55.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1699867592.0","currentOid":""},"activityList":{"items":[{"before":"7840a44a8b32e6a7491fd4fb647ff2f118785f3b","after":"3883631c5869605c73f3e4ecc20efabcde6e9cb4","ref":"refs/heads/main","pushedAt":"2024-06-07T15:14:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Improve error message for strict provisioning profile search failures\n\nSummary: Improve the error message when strict search fails to find profile.\n\nReviewed By: manicaesar\n\nDifferential Revision: D58286843\n\nfbshipit-source-id: 86de619e2bcafa39dd519ba4dc4f2afeccd7eec7","shortMessageHtmlLink":"Improve error message for strict provisioning profile search failures"}},{"before":"db423275fca0ebf38592889232a33cb5d5f4139f","after":"7840a44a8b32e6a7491fd4fb647ff2f118785f3b","ref":"refs/heads/main","pushedAt":"2024-06-06T22:29:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Disable cxx dep file uploads\n\nSummary:\nThere is a non-reproducible bug affecting dep file cache uploads where an action output other than the dep file is materialized to a dep file path but fails to be parsed as a dep file because it's not a dep file.\n\nIt almost exclusively affects cxx targets so disabling uploads for them for now while I investigate a fix.\n\nReviewed By: chatura-atapattu\n\nDifferential Revision: D58249431\n\nfbshipit-source-id: d23d3c76c2cde3fd72cb3e65abe7ea1415371660","shortMessageHtmlLink":"Disable cxx dep file uploads"}},{"before":"3803afe4209fab712543a0779d7aeef168a11b0c","after":"db423275fca0ebf38592889232a33cb5d5f4139f","ref":"refs/heads/main","pushedAt":"2024-06-06T17:27:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Don't include optional Android libraries by default\n\nSummary:\nThis matches Gradle behavior since Android SDK 23 where targets have to opt-in to using the deprecated libraries.\n\nhttps://developer.android.com/about/versions/marshmallow/android-6.0-changes.html#behavior-apache-http-client\n\nReviewed By: navidqar\n\nDifferential Revision: D57746878\n\nfbshipit-source-id: 46dc0271397e2ee9d0c431330c73cfced4985540","shortMessageHtmlLink":"Don't include optional Android libraries by default"}},{"before":"19ceb5e95a4565d9a754534a34e899bf7c9eb2b2","after":"3803afe4209fab712543a0779d7aeef168a11b0c","ref":"refs/heads/main","pushedAt":"2024-06-06T01:13:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Switch check builds to metadata-fast\n\nSummary:\n`metadata-fast` emit mode produces a lighter-weight `.rmeta` file that, importantly, excludes things like monomorphizations that are not required for type checking. This results in a build that is about 12.5% faster, when dtolnay first investigated this in D55113078.\n\nWhen backing out D57625262, it's clear to see the impact:\n\n```\n$ buck2 build fbcode//smart/glassworks_meta/prod_service:prod_service_lib[check]\n$ buck2 log what-ran | grep prod_service_lib\n# Run the action that shows from previous command\n$ time <action>\n```\n\n## Before (check [pic])\n```\nreal    1m17.872s\nuser    1m14.374s\nsys     0m3.521s\n```\n\n## After (check [fast])\n```\nreal    0m0.347s\nuser    0m0.236s\nsys     0m0.090s\n```\n\nHowever, the downside is that we may see less cache hit rate, so I'm not sure how to weigh that tradeoff. I'll start a post in buck2 dev on this.\n\nReviewed By: dtolnay\n\nDifferential Revision: D57738355\n\nfbshipit-source-id: 963dbd4252bed692ff2549cd3a680cf34fea5a1f","shortMessageHtmlLink":"Switch check builds to metadata-fast"}},{"before":"7fb2ff4bbbd52d22abb3b92954300e877d0e5224","after":"19ceb5e95a4565d9a754534a34e899bf7c9eb2b2","ref":"refs/heads/main","pushedAt":"2024-06-06T00:38:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Ensure antlir plugins use static_pic link style\n\nSummary:\nAntlir feature plugins are specially-crafted rust dylibs that are used in order to plug in different feature to antlir2. They depend on the following properties:\n\n1. The output file format is a dylib artifact.\n2. The rust code underneath the artifact is statically linked in.\n\nThese are both true today, as we have `force_rlib=True`. However, when `advanced_unstable_linking` rolls out, this will no longer be true. In order to maintain the expected behavior here, I am exposing `link_style` to rust_library targets and setting it to `static_pic` for antlir2.\n\nReviewed By: dtolnay\n\nDifferential Revision: D58169449\n\nfbshipit-source-id: 52c00b921a88579de74f4a5e9ef229b893629edd","shortMessageHtmlLink":"Ensure antlir plugins use static_pic link style"}},{"before":"1df07b44db8760b864d57fb3b32aab653e294c92","after":"7fb2ff4bbbd52d22abb3b92954300e877d0e5224","ref":"refs/heads/main","pushedAt":"2024-06-05T23:37:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fixes for advanced_unstable_linking\n\nSummary:\nA few fixes in order to make advanced_unstable_linking work, a few fixes were needed to handle compiling + linking rust code.\n\n1. Make sure hollow rlibs are always generated for metadata-full emits.\n2. Make sure that the targets themselves are added as dependencies when using advanced_unstable_linking.\n3. Apply a workaround for version scripts related to latest clang + building dylibs.\n\nReviewed By: diliop\n\nDifferential Revision: D58169850\n\nfbshipit-source-id: 15b675b3ae35ea0b00c279f47e4c9a701e990eb6","shortMessageHtmlLink":"Fixes for advanced_unstable_linking"}},{"before":"5716817090c15df4321b52886aa92ef5b063e9cc","after":"1df07b44db8760b864d57fb3b32aab653e294c92","ref":"refs/heads/main","pushedAt":"2024-06-05T22:53:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Expose soname field on rust_library\n\nSummary: Requested by tmcguire-meta on https://fb.workplace.com/groups/rustonmobile/posts/3723752194537762 in order to allow including rust shared objects into gradle builds in arvr land.\n\nReviewed By: dtolnay\n\nDifferential Revision: D58200175\n\nfbshipit-source-id: 27d6e8ed37a8c661475ca1c88db8d4269aed33d2","shortMessageHtmlLink":"Expose soname field on rust_library"}},{"before":"ed517762f9a7a3fc58119e61a649278ee2b46066","after":"5716817090c15df4321b52886aa92ef5b063e9cc","ref":"refs/heads/main","pushedAt":"2024-06-05T19:54:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make advanced_unstable_link no longer imply force_rlib=True\n\nSummary: Now that `force_rlib` is no longer true, the way that link providers are split out for stable linking does not work for unstable - there's a larger overlap between the rust link providers and native link providers. I opted to pull them out as a standalone function, which made developing the providers much easier to reason about.\n\nReviewed By: diliop\n\nDifferential Revision: D57462986\n\nfbshipit-source-id: ceaf354ec67f599fc323f67790c4cfaccf3efa0b","shortMessageHtmlLink":"Make advanced_unstable_link no longer imply force_rlib=True"}},{"before":"2385a552eca6215669b6ecea274e36d5a997588f","after":"ed517762f9a7a3fc58119e61a649278ee2b46066","ref":"refs/heads/main","pushedAt":"2024-06-05T19:10:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Removed redundant prints\n\nSummary: Committed by mistake in D57496716\n\nReviewed By: benb\n\nDifferential Revision: D58188389\n\nfbshipit-source-id: c3c0b5dc9f9d276a590af0d19d900c5e670afea6","shortMessageHtmlLink":"Removed redundant prints"}},{"before":"54efc5d8f49a16fc3126e69425c9507c5323b89b","after":"2385a552eca6215669b6ecea274e36d5a997588f","ref":"refs/heads/main","pushedAt":"2024-06-05T18:50:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Back out \"Fixing return ordering of depth_first_traversal_by\"\n\nSummary:\nOriginal commit changeset: 53aacdd3b833\n\nOriginal Phabricator Diff: D58137945\n\nDifferential Revision: D58193919\n\nfbshipit-source-id: 5c76bedcf5b2f6ef404983d4c65be94aee48312f","shortMessageHtmlLink":"Back out \"Fixing return ordering of depth_first_traversal_by\""}},{"before":"565dd03240f60cb649fd3428d861853d63c950f4","after":"54efc5d8f49a16fc3126e69425c9507c5323b89b","ref":"refs/heads/main","pushedAt":"2024-06-05T18:44:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Do not set `GHC_PACKAGE_PATH` when it is empty\n\nSummary:\nThis fixes a problem that we have seen after adding a .conf file to the project root.\n\n`ghc-pkg` interprets an empty package path as the current working directory and will try to read any\n`.conf` file from there which can lead to spurious errors like this:\n\n```\nLocal command returned non-zero exit code 1\nReproduce locally: `env -- 'BUCK_SCRATCH_PATH=buck-out/v2/tmp/root/904931f735703749/backend/src/__backend_infra__/haskel ...<omitted>... nfra__/db-static buck-out/v2/gen/root/904931f735703749/backend/src/__backend_infra__/pkg-static.conf (run `buck2 log what-failed` to get the full command)`\nstdout:\nstderr:\nWARNING: cache does not exist: ./package.cache\nghc will fail to read this package db. Use 'ghc-pkg recache' to fix.\nghc-pkg-9.8.2: \"the input\" (line 14, column 1):\nunexpected operator \"#\"\nexpecting field or section name\n```\n\nX-link: https://github.com/facebook/buck2/pull/677\n\nReviewed By: shayne-fletcher\n\nDifferential Revision: D58192347\n\nPulled By: ndmitchell\n\nfbshipit-source-id: 4b3067f4075aee7e539897b9ee3c7940fc35fcd5","shortMessageHtmlLink":"Do not set <code>GHC_PACKAGE_PATH</code> when it is empty"}},{"before":"3467f6869744bc78af857a88eb0336c3d41bc416","after":"565dd03240f60cb649fd3428d861853d63c950f4","ref":"refs/heads/main","pushedAt":"2024-06-05T18:21:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Added proper debug info json to link groups\n\nSummary: To write tests for link groups and to debug them more easily adding debug subtargets.\n\nReviewed By: fgasperij\n\nDifferential Revision: D58137942\n\nfbshipit-source-id: c6ed61c91a9bcc21c9922e0058ff383f4518c425","shortMessageHtmlLink":"Added proper debug info json to link groups"}},{"before":"bd99fc8cc87b4b886bbc45b3d4fc5afb80c6eba6","after":"3467f6869744bc78af857a88eb0336c3d41bc416","ref":"refs/heads/main","pushedAt":"2024-06-05T18:06:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"cmd_args .hidden() -> hidden=\n\nSummary: Following diff D58047333 removes `cmd_args.hidden()`.\n\nReviewed By: blackm00n\n\nDifferential Revision: D58044431\n\nfbshipit-source-id: df7bc4e5f30decfc2b359921a8eeea94aedb193b","shortMessageHtmlLink":"cmd_args .hidden() -&gt; hidden="}},{"before":"22193326e07177f605434278c9a47751a5802417","after":"bd99fc8cc87b4b886bbc45b3d4fc5afb80c6eba6","ref":"refs/heads/main","pushedAt":"2024-06-05T15:51:38.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"def argfile\n\nSummary:\nWrapper for `ctx.actions.write` which attaches dependencies.\n\nI think `ctx.actions.write(with_inputs=True)` could be used, but it does not work properly, a comment says \"This will only work for bound artifacts\". I don't know if we can fix it, if we do, we can inline this function back.\n\nThis function is slightly more expensive than using `write` directly (we create extra `cmd_args`), but\n- how much, depends on what you are doing (see benchmark below)\n- we will win it back when we make `cmd_args` immutable\n\nUsed it in `prelude/android`, because this is what I migrate now from `cmd_args.hidden()` calls.\n\nReviewed By: blackm00n\n\nDifferential Revision: D58041951\n\nfbshipit-source-id: 219664061bef3f145ccc719a4e839ddf3376d627","shortMessageHtmlLink":"def argfile"}},{"before":"1a76cd788d5ced8397c9b583632f4cb11b8afb27","after":"22193326e07177f605434278c9a47751a5802417","ref":"refs/heads/main","pushedAt":"2024-06-05T15:09:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert D58170645: Revert D58137945: Multisect successfully blamed \"D58137945: [link_groups] Fixing return ordering of depth_first_traversal_by\" for one test failure\n\nDifferential Revision:\nD58170645\n\nOriginal commit changeset: 9faf378115e2\n\nOriginal Phabricator Diff: D58170645\n\nfbshipit-source-id: 3b34ebd10ffcca56b207b9f7651772c21d2ee94f","shortMessageHtmlLink":"Revert D58170645: Revert D58137945: Multisect successfully blamed \"D5…"}},{"before":"07f54a5ef5af3a6128e1c64300d7587b38316e77","after":"1a76cd788d5ced8397c9b583632f4cb11b8afb27","ref":"refs/heads/main","pushedAt":"2024-06-05T13:47:55.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"buck2 | Allow apple_bundle_resources to get the split-transition binaries\n\nSummary:\napple_bundle_resources() is currently designated as receiving an `attrs.dep()` for its 'binary' parameter.\n\nHowever, apple_bundle() receives an `attrs.split_transition_dep()` because it can build universal binaries for that dep.\n\n1) This diff adds the split_transition_dep to the apple_bundle_resources definition so that binaries from each separate compile can be accessed. This is needed because swift apple frameworks contain files from each architecture inside the `ModuleName.swiftmodule/` directory.\n\n2) This diff uses the split transition to get files from both sides of a universal binary compilation inside _copy_swift_library_evolution_support(). The success of this is tested in the fbobjc/buck2/tests test fixture.\n\n3) apple_resource_bundle contains a [transition](https://www.internalfb.com/code/fbsource/[f1a4be71e3e675b7712dcd2a41ce30160d63403c]/fbcode/buck2/prelude/apple/user/apple_resource_transition.bzl) to dedupe resource dependencies. See the Summary of D51156753 for more info. The logic is that it strips all CPU target info, so each resource ends up evaluating to the same configuration, and we don't get bogus duplicates mapping to the same target path. This diff adds some changes to this logic:\na) It extends this transition to apple_asset_catalog which also needs deduping with the change in 1)\nb) Many resource bundles opted-out because they needed to build a universal binary, which this transition would have disabled. They could opt-out safely because they previously were bundled under the non-split-transition logic. Now we exposed the split-transition to apple_bundle_resources we end up with duplicate deps. To resolve this we modify the apple_resource_transition to allow the universal constraint to remain. This means that resource targets under this transition can still build universal binaries (i.e. all the *CrashpadHander binaries that tend to be involved should be universal). We then opt back into this transition everywhere.\n\nWhy was the universal constraint ever stripped? I guess it counts as CPU targeting info, and if our universal binary split transition stripped 'universal' from the platform, we would also need to strip it here. But (from [examining the code](https://www.internalfb.com/code/fbsource/[96bddf5ac8d33bc0d24b3bda00df06aac2cc8fab]/fbcode/buck2/prelude/apple/user/cpu_split_transition.bzl)) we don't so it should be safe.\n\nThese changes are all rolled into one diff because they need to land / be rolled back atomically.\n\nReviewed By: blackm00n\n\nDifferential Revision: D57496716\n\nfbshipit-source-id: 01db1b0aa54455a040f7a0aeb52d37886155de89","shortMessageHtmlLink":"buck2 | Allow apple_bundle_resources to get the split-transition bina…"}},{"before":"7bd619238eb63afa809c49fc66bc84527740d9b4","after":"07f54a5ef5af3a6128e1c64300d7587b38316e77","ref":"refs/heads/main","pushedAt":"2024-06-05T11:58:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert D58137945: Multisect successfully blamed \"D58137945: [link_groups] Fixing return ordering of depth_first_traversal_by\" for one test failure\n\nSummary:\nThis diff reverts D58137945\nD58137945: [link_groups] Fixing return ordering of depth_first_traversal_by by Nekitosss causes the following test failure:\n\nTests affected:\n- [cogwheel:cogwheel_autogen_basic_requests#main](https://www.internalfb.com/intern/test/562950057491189/)\n\nHere's the Multisect link:\nhttps://www.internalfb.com/multisect/5308083\nHere are the tasks that are relevant to this breakage:\nT191382884: 10+ tests unhealthy for avatar_ml_foundation\n\nThe backout may land if someone accepts it.\n\nIf this diff has been generated in error, you can Commandeer and Abandon it.\n\nReviewed By: artempyanykh\n\nDifferential Revision: D58170645\n\nfbshipit-source-id: 9faf378115e2fc53a8ad03f32f931571e873c6f1","shortMessageHtmlLink":"Revert D58137945: Multisect successfully blamed \"D58137945: [link_gro…"}},{"before":"0f9c37d1959eb651ced674d66edb2fcac299a192","after":"7bd619238eb63afa809c49fc66bc84527740d9b4","ref":"refs/heads/main","pushedAt":"2024-06-05T03:31:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Allow passing source to `exe` param\n\nSummary:\nThis avoids the need for the user to create yet another rule just\nto wrap a simple script w/ `command_alias`.\n\nReviewed By: stepancheg\n\nDifferential Revision: D58099067\n\nfbshipit-source-id: fd7790a02a3dc56621eff68ae02c89667bad8916","shortMessageHtmlLink":"Allow passing source to <code>exe</code> param"}},{"before":"ca1d70f4797757fa68172ff95aa18e509661aa92","after":"0f9c37d1959eb651ced674d66edb2fcac299a192","ref":"refs/heads/main","pushedAt":"2024-06-05T03:05:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add abstraction to handle paths behind symlinks\n\nSummary:\nThis adds a new tuple-like record, `ArtifactExt`, to model paths\nbehind symlinks to other read-only filesystems.   This record\nholds both the path to the symlink and the sub-path behind it.\nThe former is modeled as an `Artifact` which buck2 can track\nand the latter is a string to append onto the former when referencing\nthe path in command.\n\nReviewed By: igorsugak\n\nDifferential Revision: D57117351\n\nfbshipit-source-id: ba3efbf0566327635b746161f343eb2b823e2171","shortMessageHtmlLink":"Add abstraction to handle paths behind symlinks"}},{"before":"cd1a2d7df40dbce16d695361b27f9f016812f7f9","after":"ca1d70f4797757fa68172ff95aa18e509661aa92","ref":"refs/heads/main","pushedAt":"2024-06-05T01:18:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Guard K2 usage on builds that use `force_k1` at the Kotlin toolchain level\n\nSummary: Bringing back logic that we have for D57382321 to make sure we don't use K2 in builds that specify `kotlin.frontend_compiler=force_k1`.\n\nReviewed By: nghuiqin\n\nDifferential Revision: D58091253\n\nfbshipit-source-id: a03e21cabe0c59255be2b1f88505f733c97e4c6b","shortMessageHtmlLink":"Guard K2 usage on builds that use <code>force_k1</code> at the Kotlin toolchain …"}},{"before":"220b3d97ae238f10d079f1364d1ab366ae364492","after":"cd1a2d7df40dbce16d695361b27f9f016812f7f9","ref":"refs/heads/main","pushedAt":"2024-06-04T21:37:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove some dead code\n\nSummary: `command` is already added as dependency in the previous line.\n\nReviewed By: blackm00n\n\nDifferential Revision: D58032691\n\nfbshipit-source-id: fd1fd50e348ef32ce2709fc4815f2de2c8ad7935","shortMessageHtmlLink":"Remove some dead code"}},{"before":"97b6071408c74311cce462165871b271a76d54dc","after":"220b3d97ae238f10d079f1364d1ab366ae364492","ref":"refs/heads/main","pushedAt":"2024-06-04T21:30:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix a bunch of licenselint problems\n\nSummary:\nX-link: https://github.com/pytorch/executorch/pull/3834\n\nI made this worse when I added a bunch of things to the shim. Oops.\n\nbypass-github-export-checks\n\nReviewed By: zertosh\n\nDifferential Revision: D58112226\n\nfbshipit-source-id: f5ad92f4438bec72035cc2cecd79d16aa638387f","shortMessageHtmlLink":"Fix a bunch of licenselint problems"}},{"before":"7f1d7b5befbcd68cbfe4ef5f5c9547b109421c9c","after":"97b6071408c74311cce462165871b271a76d54dc","ref":"refs/heads/main","pushedAt":"2024-06-04T21:06:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert D58142324: Removing a default abi override in pure Java modules\n\nDifferential Revision:\nD58142324\n\nOriginal commit changeset: a55f11f2a4a0\n\nOriginal Phabricator Diff: D58142324\n\nfbshipit-source-id: ba57c4b43336284681ead7bab7a9702302813b5e","shortMessageHtmlLink":"Revert D58142324: Removing a default abi override in pure Java modules"}},{"before":"bd77f2ae2a73f580133539bd593013363aca89d9","after":"7f1d7b5befbcd68cbfe4ef5f5c9547b109421c9c","ref":"refs/heads/main","pushedAt":"2024-06-04T19:36:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"extend at_argfile to support allow_args=True\n\nReviewed By: blackm00n\n\nDifferential Revision: D58027791\n\nfbshipit-source-id: ec6603e796af71e237063d166f3530b8c313b7bd","shortMessageHtmlLink":"extend at_argfile to support allow_args=True"}},{"before":"c672387e152dcbd9798f5363ddb7d136330e10b8","after":"bd77f2ae2a73f580133539bd593013363aca89d9","ref":"refs/heads/main","pushedAt":"2024-06-04T19:24:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Removing a default abi override in pure Java modules\n\nSummary:\nAs suggested in https://fb.workplace.com/groups/2840058936242210/posts/3737461749835253/?comment_id=3737504709830957\n\nthis diff reverts D42098016 and removes a a default override for  Java abi mode\n\nDifferential Revision: D58142324\n\nfbshipit-source-id: a55f11f2a4a0250f57546a27a056cd7a23a8049e","shortMessageHtmlLink":"Removing a default abi override in pure Java modules"}},{"before":"1f8c948247529d80f07a84b0ad67d10015c4c406","after":"c672387e152dcbd9798f5363ddb7d136330e10b8","ref":"refs/heads/main","pushedAt":"2024-06-04T16:59:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Re-commit D57889230\n\nSummary:\nA second attempt at fixing the duplicate member bug in dist_lto_prepare.py. Original diff: D57889230. In\nthe previous attempt to land, adfinder and some other important builds broke.\n\nThe previous attempt failed because we used os.rename to rename a file between\nfile systems: https://www.internalfb.com/sandcastle/workflow/3265109729846704586\n\n```\nFile \"/re_cwd/buck-out/v2/gen/prelude/898ad24bd92b3725/cxx/dist_lto/tools/__dist_lto_prepare__/dist_lto_prepare.py\", line 130, in main\n    os.rename(\nOSError: [Errno 18] Invalid cross-device link: '/re_tmp/tmpefr1sgsc/cpu.o' -> '/re_cwd/buck-out/v2/gen/fbcode/af046fc34ed1558a/admarket/adfinder/__adfinder_hottext__/thin_lto_prepare_executable/avutil/lib/libavutil.a/objects/cpu.o'\n```\n\nThe docs specify to use `shutil.move` in this case, so that's what I've done in the second attempt:\n\n> The operation may fail if src and dst are on different filesystems. Use shutil.move() to support moves to a different filesystem.\n\nhttps://docs.python.org/3/library/os.html#os.rename\n\n#buildmore\n\nReviewed By: kyulee-com\n\nDifferential Revision: D58110917\n\nfbshipit-source-id: 1f80bea25f741702444a302c8d87b481c36685c2","shortMessageHtmlLink":"Re-commit D57889230"}},{"before":"f788f5196c229f5e523dab13a4cb0e24ceae7cec","after":"1f8c948247529d80f07a84b0ad67d10015c4c406","ref":"refs/heads/main","pushedAt":"2024-06-04T16:04:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fixing return ordering of depth_first_traversal_by\n\nSummary:\nThe original is D57905416.\n`preorder-left-to-right` by default was backed out D58097382 due to runtime failures. Investigation showed that it was not implemented correctly.\n`depth_first_traversal_by` does two things:\n1. Calls `get_nodes_to_traverse_func` for each node. That was called with correct `preorder-left-to-right` order as expected.\n2. Returns the list of all elements that was walked throught. **We had an error here**. We can't use `visited` list for returning results. `visited` does *not* always ordered in the same way. If we have more than one `roots` passed the order was broken.\n\nSolving it by defining explicit list for return and fill it in the exact same way I do traversal. Now everything works!\n\nReviewed By: artempyanykh\n\nDifferential Revision: D58137945\n\nfbshipit-source-id: 53aacdd3b833de48e7e91e01a2ef10fefee81252","shortMessageHtmlLink":"Fixing return ordering of depth_first_traversal_by"}},{"before":"cf2ebdd1748eef40e1d768473089b80da3ea25e8","after":"f788f5196c229f5e523dab13a4cb0e24ceae7cec","ref":"refs/heads/main","pushedAt":"2024-06-04T12:12:55.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix a lint warning\n\nSummary: Might as well.\n\nReviewed By: blackm00n\n\nDifferential Revision: D58132750\n\nfbshipit-source-id: 279940b2ff5e84790cef49f6923a2155b67454e4","shortMessageHtmlLink":"Fix a lint warning"}},{"before":"fdeb4ae4de2f804dfb3180b04b5c1f05d89d5ead","after":"cf2ebdd1748eef40e1d768473089b80da3ea25e8","ref":"refs/heads/main","pushedAt":"2024-06-04T10:40:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Update the copyright header\n\nReviewed By: fgasperij\n\nDifferential Revision: D58130789\n\nfbshipit-source-id: ebc8c5cb2a251d63d2dee9fe747f0c0e3a856744","shortMessageHtmlLink":"Update the copyright header"}},{"before":"0dc2658455a3de82309280d77fdeee0bb6f754cc","after":"fdeb4ae4de2f804dfb3180b04b5c1f05d89d5ead","ref":"refs/heads/main","pushedAt":"2024-06-03T22:03:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Revert D57947241: Clean up jdk7 dependencies\n\nDifferential Revision:\nD57947241\n\nOriginal commit changeset: c1885124019e\n\nOriginal Phabricator Diff: D57947241\n\nfbshipit-source-id: b2162ecfcb9a8e557a1d4a6a5aa630b000537819","shortMessageHtmlLink":"Revert D57947241: Clean up jdk7 dependencies"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEX1rdnwA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/buck2-prelude"}