Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jest 27 #10747

Closed
gaearon opened this issue Mar 25, 2021 · 17 comments · Fixed by #11338
Closed

Update to Jest 27 #10747

gaearon opened this issue Mar 25, 2021 · 17 comments · Fixed by #11338

Comments

@gaearon
Copy link
Contributor

gaearon commented Mar 25, 2021

There's a bugfix in React that we need to make. Unfortunately, there's a risk of that change breaking some tests. In order to fix the tests, you'd have to upgrade Jest. But if you use Jest via CRA, you can't do this directly.

We need to upgrade CRA to Jest 27 so that we can unblock React from making this bugfix. Jest 27 isn't out yet, but we can start testing the integration using the 27.0.0-next.6 version.

Does anyone want to take this on?

@ankurkaushal
Copy link

I definitely would love to take this on :)

@gaearon
Copy link
Contributor Author

gaearon commented Mar 25, 2021

Thanks @ankurkaushal, please feel free to send a PR! Please keep in mind that the timing is somewhat sensitive so we'd like to avoid the situation where you give up on the work but no one else knows or picks it up. I think it's fair that this issue isn't taken exclusively, and if someone else ends up doing it before, we'll be reviewing that.

@ankurkaushal
Copy link

@gaearon: Thanks, I will try to put up a PR as soon as possible!

@SimenB
Copy link
Contributor

SimenB commented Mar 25, 2021

As an aside, updating to v27 will close #9993 (as it'll be the default and you can remove the config)

@sauldeleon
Copy link

Hi! how is this going?

I have seen that Jest has released final version 27 a couple of days ago. Any chance of react-scripts to update to v27 to??

Thanks!

@jasonlimantoro
Copy link

jasonlimantoro commented Jun 1, 2021

Sounds like the related PR #10748 is no longer progressing. Therefore, in the meantime, unable to use Jest v27 with CRA.

@ankurkaushal
Copy link

@jasonlimantoro: Having some issues with the upgrade like I mentioned in my PR, will get back to it today & see if I can still fix it. I would love to have another pair of eyes on that.

@sauldeleon
Copy link

@ankurkaushal may I clone the branch and have a look if you don't mind?

@jasonlimantoro
Copy link

@ankurkaushal Hey thanks for your response. No rush though, because Jest v27 itself is still unstable and even has some regressions. Not sure if any of those bugs would affect your PR. Probably, upgrading to Jest v27 itself (while it is still unstable) is already a mistake.

@ankurkaushal
Copy link

@sauldeleon: Sure! go ahead.

@jasonlimantoro: Wasn't aware of the regressions in jest 27, may be that's cause of failing tests 🤔

@sauldeleon
Copy link

Ok, I will push this a little this weekend to see if we can achieve this. Sorry for not doing anything before!

@ankurkaushal
Copy link

@sauldeleon No worries! I will probably look again too if I get some time.

@edgmark
Copy link

edgmark commented Jun 30, 2021

Also hoping for jest 27 support due to a nested vulnerability with jest 26:

jest@26.6.0 > @jest/core@26.6.3 > jest-config@26.6.3 > jest-environment-jsdom@26.6.2 > jsdom@16.5.0 > request@2.88.2 -- SNYK#SNYK-JS-REQUEST-1314897 Insecure Encryption. Upgrade jest to 27.0.6

@krreet
Copy link
Contributor

krreet commented Aug 28, 2021

@gaearon @SimenB @ankurkaushal
Please check this PR which updates jest to 27.1.0
#11338

@krreet
Copy link
Contributor

krreet commented Sep 3, 2021

Hi
@petetnt , @elektronik2k5 , @iansu , @mrmckeb , @SimenB , @gaearon , @sauldeleon .

Wanted to grab your attention to PR #11338 ,
which should close this issue and also this issue #9993 and few other related issues.

Please review the PR so that it can be merged. All the issues have been resolved and the PR should be good to merge.

@sauldeleon
Copy link

top!!!!!

@SimenB
Copy link
Contributor

SimenB commented Sep 23, 2021

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants