Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in jsx-no-target-blank eslint rule #2774

Closed
green-arrow opened this issue Jul 12, 2017 · 6 comments
Closed

Bug in jsx-no-target-blank eslint rule #2774

green-arrow opened this issue Jul 12, 2017 · 6 comments

Comments

@green-arrow
Copy link

Is this a bug report?

Yes

Can you also reproduce the problem with npm 4.x?

Yes

Which terms did you search for in User Guide?

N/A

Environment

  1. node -v: 7.8.0
  2. npm -v: 4.2.0
  3. yarn --version (if you use Yarn): 0.27.5
  4. npm ls react-scripts (if you haven’t ejected): 1.0.10

Then, specify:

  1. Operating system: macOS Sierra
  2. Browser and version (if relevant): Not relevant

Steps to Reproduce

  1. Insert an a tag with target="_blank" rel="noopener noreferrer" and some styles from glamor
  2. Run via yarn start

Expected Behavior

No errors.

Actual Behavior

Unexpected error in console: TypeError: Cannot read property 'name' of undefined in the jsx-no-target-blank eslint rule.

Additional Comments

I filed a bug in the eslint repo: jsx-eslint/eslint-plugin-react#1296

I am unable to reproduce this with a fresh app. This started occurring after upgrading from 1.0.4 to 1.0.10. I've tried removing node_modules and yarn.lock and installing from scratch, but still get the same error.

@green-arrow
Copy link
Author

This should be resolved once jsx-eslint/eslint-plugin-react#1298 is released.

@gaearon gaearon added this to the 1.0.x milestone Jul 14, 2017
@bondz
Copy link
Contributor

bondz commented Aug 11, 2017

jsx-eslint/eslint-plugin-react#129 is released now in 7.2.0

@nkpgardose
Copy link

Does this still happen to you guys? Having the same error.

@anonrig
Copy link

anonrig commented Oct 23, 2017

This is happening to me too.

@Timer
Copy link
Contributor

Timer commented Oct 23, 2017

Will be fixed in next release per plugin upgrade: #3146.

@Timer Timer closed this as completed Oct 23, 2017
@Timer Timer modified the milestones: 1.0.x, 1.0.15 Oct 23, 2017
@gaearon
Copy link
Contributor

gaearon commented Oct 30, 2017

Should be fixed in react-scripts@1.0.15.

https://github.com/facebookincubator/create-react-app/releases/tag/v1.0.15

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants