Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reportFile should allow TypeScript tests #6170

Closed
matthewdordal opened this issue Jan 10, 2019 · 5 comments
Closed

reportFile should allow TypeScript tests #6170

matthewdordal opened this issue Jan 10, 2019 · 5 comments

Comments

@matthewdordal
Copy link

matthewdordal commented Jan 10, 2019

Is this a bug report? No

I'm using CRA with TypeScript and followed the docs to integrate typescript.

My problem is that npm run build does not fail when there is a TypeScript error in the tests. I noticed that the webpack.config.js ignores errors in test files. See the reportFiles array. It would be awesome to report TypeScript errors in test files too so that a team can know if a change caused a TypeScript error in a test.

Alternatively, npm test should report TypeScript errors.

@kamranayub
Copy link

Note too in the react-scripts-ts fork this was supported so those of us migrating to CRA from there would expect this.

@kumar303
Copy link

This looks like a dupe of #5626

Our current workaround is to run tsc as a CI build step. This will report type errors in test files.

@stale
Copy link

stale bot commented Feb 15, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Feb 15, 2019
@stale
Copy link

stale bot commented Mar 18, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Mar 18, 2019
@ianschmitz
Copy link
Contributor

Closing as dupe of #5626.

@lock lock bot locked and limited conversation to collaborators Mar 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants