Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRA 3 : Correct link to service worker doc #6666

Closed
codingdash opened this issue Mar 17, 2019 · 2 comments
Closed

CRA 3 : Correct link to service worker doc #6666

codingdash opened this issue Mar 17, 2019 · 2 comments

Comments

@codingdash
Copy link

Started from #6475

In example src/index.js in following comment the link needs to be updated.

// If you want your app to work offline and load faster, you can change
// unregister() to register() below. Note this comes with some pitfalls.
// Learn more about service workers: https://bit.ly/CRA-PWA
serviceWorker.unregister();

From https://bit.ly/CRA-PWA -> https://facebook.github.io/create-react-app/docs/making-a-progressive-web-app

@ianschmitz
Copy link
Contributor

We are aware of the outdated bit.ly links (#5910). In the mean time would you like to submit a PR to update the link?

@codingdash
Copy link
Author

@ianschmitz Here it goes #6668, please take a look at it.

@iansu iansu closed this as completed Mar 17, 2019
@lock lock bot locked and limited conversation to collaborators Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants