Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TypeScript 3.8 #8675

Closed
levrik opened this issue Mar 19, 2020 · 2 comments
Closed

Support TypeScript 3.8 #8675

levrik opened this issue Mar 19, 2020 · 2 comments

Comments

@levrik
Copy link
Contributor

levrik commented Mar 19, 2020

Can't use the new type imports introduced by TypeScript 3.8

SyntaxError: /Users/levrik/code/<redacted>/src/theme.ts: Unexpected token (3:12)

  1 | import { createMuiTheme, emphasize } from '@material-ui/core/styles';
  2 | import createPalette from '@material-ui/core/styles/createPalette';
> 3 | import type { SkeletonClassKey } from '@material-ui/lab/Skeleton';

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html#type-only-imports-exports

react-script 3.4.0
TypeScript 3.8.0

@MichaelDeBoey
Copy link
Contributor

Closed by #8681

@ianschmitz
Copy link
Contributor

This should be available in react-scripst@3.4.1.

@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants