Fix dotenv file loading order #9037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timer
requested review from
amyrlam,
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
iansu
approved these changes
May 20, 2020
petetnt
approved these changes
May 20, 2020
rodoabad
approved these changes
May 21, 2020
|
Thanks Joe. Looks like a test needs to be updated. |
|
Thanks @mrmckeb for handling the test updates! |
rfreling
pushed a commit
to rfreling/create-react-app
that referenced
this pull request
May 30, 2020
* Fix dotenv file loading order * tests: fix failing env tests * tests: fix more failing tests Co-authored-by: Brody McKee <mrmckeb@hotmail.com>
|
No problem, I know you're super busy. |
victor-travelperk
pushed a commit
to travelperk/create-react-app
that referenced
this pull request
Jun 8, 2020
* Fix dotenv file loading order * tests: fix failing env tests * tests: fix more failing tests Co-authored-by: Brody McKee <mrmckeb@hotmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the loading priority order to match that of the
dotenvspec:https://github.com/bkeepers/dotenv#what-other-env-files-can-i-use