From d775f9416beb5a15e62f9019fa9c7aeaa5e17c35 Mon Sep 17 00:00:00 2001 From: Parth Narielwala Date: Wed, 10 Apr 2019 14:40:23 -0500 Subject: [PATCH 1/3] Fix mini-css-extract-plugin warnings Fix order warnings for CSS modules --- packages/react-scripts/config/webpack.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index a41d60e69bc..df11fb5b6ef 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -81,7 +81,7 @@ module.exports = function(webpackEnv) { const getStyleLoaders = (cssOptions, preProcessor) => { const loaders = [ isEnvDevelopment && require.resolve('style-loader'), - isEnvProduction && { + isEnvProduction && !cssOptions.modules && { loader: MiniCssExtractPlugin.loader, options: Object.assign( {}, From bfa989697f73e47bd2da82c7b87c5a04a1dde025 Mon Sep 17 00:00:00 2001 From: Parth Narielwala Date: Wed, 21 Oct 2020 17:58:00 -0400 Subject: [PATCH 2/3] use ignoreOrder param --- packages/react-scripts/config/webpack.config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index df11fb5b6ef..429333537ab 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -591,6 +591,7 @@ module.exports = function(webpackEnv) { // both options are optional filename: 'static/css/[name].[contenthash:8].css', chunkFilename: 'static/css/[name].[contenthash:8].chunk.css', + ignoreOrder: true, }), // Generate a manifest file which contains a mapping of all asset filenames // to their corresponding output file so that tools can pick it up without From ffe07a455dd2bda16eab70d6a5ff2b1827b4eb67 Mon Sep 17 00:00:00 2001 From: Parth Narielwala Date: Wed, 21 Oct 2020 18:21:01 -0400 Subject: [PATCH 3/3] remove old change --- packages/react-scripts/config/webpack.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/config/webpack.config.js b/packages/react-scripts/config/webpack.config.js index 429333537ab..943a9175ca7 100644 --- a/packages/react-scripts/config/webpack.config.js +++ b/packages/react-scripts/config/webpack.config.js @@ -81,7 +81,7 @@ module.exports = function(webpackEnv) { const getStyleLoaders = (cssOptions, preProcessor) => { const loaders = [ isEnvDevelopment && require.resolve('style-loader'), - isEnvProduction && !cssOptions.modules && { + isEnvProduction && { loader: MiniCssExtractPlugin.loader, options: Object.assign( {},