From f036744a351bb6fd9909a721aea46d37492ac152 Mon Sep 17 00:00:00 2001 From: Mostafa Nawara Date: Sat, 4 May 2019 00:34:12 +0200 Subject: [PATCH 1/2] Add note to restart the dev server after change .env file --- docusaurus/docs/adding-custom-environment-variables.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docusaurus/docs/adding-custom-environment-variables.md b/docusaurus/docs/adding-custom-environment-variables.md index 0e635f6a3c0..e2d3f9080bf 100644 --- a/docusaurus/docs/adding-custom-environment-variables.md +++ b/docusaurus/docs/adding-custom-environment-variables.md @@ -117,6 +117,8 @@ REACT_APP_NOT_SECRET_CODE=abcdef > Note: You must create custom environment variables beginning with `REACT_APP_`. Any other variables except `NODE_ENV` will be ignored to avoid [accidentally exposing a private key on the machine that could have the same name](https://github.com/facebook/create-react-app/issues/865#issuecomment-252199527). Changing any environment variables will require you to restart the development server if it is running. +> Note: You need to restart the development server after change `.env` file. + `.env` files **should be** checked into source control (with the exclusion of `.env*.local`). ### What other `.env` files can be used? From 4b207eaf1707178de10a4d83aabdef2d9eff1ab3 Mon Sep 17 00:00:00 2001 From: Ian Sutherland Date: Sun, 5 May 2019 17:31:12 +0200 Subject: [PATCH 2/2] Update copy Co-Authored-By: MostafaNawara --- docusaurus/docs/adding-custom-environment-variables.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docusaurus/docs/adding-custom-environment-variables.md b/docusaurus/docs/adding-custom-environment-variables.md index e2d3f9080bf..97fc21fd11d 100644 --- a/docusaurus/docs/adding-custom-environment-variables.md +++ b/docusaurus/docs/adding-custom-environment-variables.md @@ -117,7 +117,7 @@ REACT_APP_NOT_SECRET_CODE=abcdef > Note: You must create custom environment variables beginning with `REACT_APP_`. Any other variables except `NODE_ENV` will be ignored to avoid [accidentally exposing a private key on the machine that could have the same name](https://github.com/facebook/create-react-app/issues/865#issuecomment-252199527). Changing any environment variables will require you to restart the development server if it is running. -> Note: You need to restart the development server after change `.env` file. +> Note: You need to restart the development server after changing `.env` files. `.env` files **should be** checked into source control (with the exclusion of `.env*.local`).