From af82b6388f00c4a4d786b1c735c725e9f6af1521 Mon Sep 17 00:00:00 2001 From: Katherine Connolly Date: Wed, 26 Feb 2020 15:07:52 -0700 Subject: [PATCH 1/5] added strictmode tags to default templates --- packages/cra-template-typescript/template/src/App.tsx | 2 ++ packages/cra-template/template/src/App.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/packages/cra-template-typescript/template/src/App.tsx b/packages/cra-template-typescript/template/src/App.tsx index a53698aab3c..5e429286e42 100644 --- a/packages/cra-template-typescript/template/src/App.tsx +++ b/packages/cra-template-typescript/template/src/App.tsx @@ -4,6 +4,7 @@ import './App.css'; function App() { return ( +
logo @@ -20,6 +21,7 @@ function App() {
+
); } diff --git a/packages/cra-template/template/src/App.js b/packages/cra-template/template/src/App.js index ce9cbd2946d..a55f046c3f4 100644 --- a/packages/cra-template/template/src/App.js +++ b/packages/cra-template/template/src/App.js @@ -4,6 +4,7 @@ import './App.css'; function App() { return ( +
logo @@ -20,6 +21,7 @@ function App() {
+
); } From 3c658f01a112520556e18c36de8c876bdb39c10f Mon Sep 17 00:00:00 2001 From: Katherine Connolly Date: Sat, 7 Mar 2020 12:05:32 -0700 Subject: [PATCH 2/5] fixed formatting, wrapped index --- .../template/src/App.tsx | 32 +++++++++---------- .../template/src/index.tsx | 2 +- packages/cra-template/template/src/App.js | 32 +++++++++---------- packages/cra-template/template/src/index.js | 7 +++- 4 files changed, 39 insertions(+), 34 deletions(-) diff --git a/packages/cra-template-typescript/template/src/App.tsx b/packages/cra-template-typescript/template/src/App.tsx index 5e429286e42..d7e3cc3fb21 100644 --- a/packages/cra-template-typescript/template/src/App.tsx +++ b/packages/cra-template-typescript/template/src/App.tsx @@ -5,22 +5,22 @@ import './App.css'; function App() { return ( -
-
- logo -

- Edit src/App.tsx and save to reload. -

- - Learn React - -
-
+
+
+ logo +

+ Edit src/App.tsx and save to reload. +

+ + Learn React + +
+
); } diff --git a/packages/cra-template-typescript/template/src/index.tsx b/packages/cra-template-typescript/template/src/index.tsx index 87d1be55189..d7572e6fe16 100644 --- a/packages/cra-template-typescript/template/src/index.tsx +++ b/packages/cra-template-typescript/template/src/index.tsx @@ -4,7 +4,7 @@ import './index.css'; import App from './App'; import * as serviceWorker from './serviceWorker'; -ReactDOM.render(, document.getElementById('root')); +ReactDOM.render(, document.getElementById('root')); // If you want your app to work offline and load faster, you can change // unregister() to register() below. Note this comes with some pitfalls. diff --git a/packages/cra-template/template/src/App.js b/packages/cra-template/template/src/App.js index a55f046c3f4..f52d97d2daa 100644 --- a/packages/cra-template/template/src/App.js +++ b/packages/cra-template/template/src/App.js @@ -5,22 +5,22 @@ import './App.css'; function App() { return ( -
-
- logo -

- Edit src/App.js and save to reload. -

- - Learn React - -
-
+
+
+ logo +

+ Edit src/App.js and save to reload. +

+ + Learn React + +
+
); } diff --git a/packages/cra-template/template/src/index.js b/packages/cra-template/template/src/index.js index 87d1be55189..f5185c1ec7a 100644 --- a/packages/cra-template/template/src/index.js +++ b/packages/cra-template/template/src/index.js @@ -4,7 +4,12 @@ import './index.css'; import App from './App'; import * as serviceWorker from './serviceWorker'; -ReactDOM.render(, document.getElementById('root')); +ReactDOM.render( + + + , + document.getElementById('root') +); // If you want your app to work offline and load faster, you can change // unregister() to register() below. Note this comes with some pitfalls. From c3da1d0835d92b286d118ff3e28cc9201f8d2f87 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Sun, 8 Mar 2020 14:52:41 +0000 Subject: [PATCH 3/5] Remove unnecessary change --- packages/cra-template/template/src/App.js | 34 +++++++++++------------ 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/packages/cra-template/template/src/App.js b/packages/cra-template/template/src/App.js index f52d97d2daa..ce9cbd2946d 100644 --- a/packages/cra-template/template/src/App.js +++ b/packages/cra-template/template/src/App.js @@ -4,24 +4,22 @@ import './App.css'; function App() { return ( - -
-
- logo -

- Edit src/App.js and save to reload. -

- - Learn React - -
-
-
+
+
+ logo +

+ Edit src/App.js and save to reload. +

+ + Learn React + +
+
); } From bfbe805920488a801b6ba0e76722b79283010b1f Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Sun, 8 Mar 2020 14:53:02 +0000 Subject: [PATCH 4/5] Remove unnecessary change --- .../template/src/App.tsx | 34 +++++++++---------- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/packages/cra-template-typescript/template/src/App.tsx b/packages/cra-template-typescript/template/src/App.tsx index d7e3cc3fb21..a53698aab3c 100644 --- a/packages/cra-template-typescript/template/src/App.tsx +++ b/packages/cra-template-typescript/template/src/App.tsx @@ -4,24 +4,22 @@ import './App.css'; function App() { return ( - -
-
- logo -

- Edit src/App.tsx and save to reload. -

- - Learn React - -
-
-
+
+
+ logo +

+ Edit src/App.tsx and save to reload. +

+ + Learn React + +
+
); } From 3b5f16eed60ed6834d60bb921dd97f8cb1e9f4a3 Mon Sep 17 00:00:00 2001 From: Dan Abramov Date: Sun, 8 Mar 2020 14:53:41 +0000 Subject: [PATCH 5/5] Tweak format --- packages/cra-template-typescript/template/src/index.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/cra-template-typescript/template/src/index.tsx b/packages/cra-template-typescript/template/src/index.tsx index d7572e6fe16..f5185c1ec7a 100644 --- a/packages/cra-template-typescript/template/src/index.tsx +++ b/packages/cra-template-typescript/template/src/index.tsx @@ -4,7 +4,12 @@ import './index.css'; import App from './App'; import * as serviceWorker from './serviceWorker'; -ReactDOM.render(, document.getElementById('root')); +ReactDOM.render( + + + , + document.getElementById('root') +); // If you want your app to work offline and load faster, you can change // unregister() to register() below. Note this comes with some pitfalls.