Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner covers menu on mobile #8141

Closed
2 of 7 tasks
SimenB opened this issue Sep 28, 2022 · 3 comments · Fixed by #8163
Closed
2 of 7 tasks

Banner covers menu on mobile #8141

SimenB opened this issue Sep 28, 2022 · 3 comments · Fixed by #8163
Labels
bug An error in the Docusaurus core causing instability or issues with its execution domain: theme Related to the default theme components

Comments

@SimenB
Copy link
Contributor

SimenB commented Sep 28, 2022

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

screen-20220928-103739.mp4

https://jestjs.io/docs/cli#--filterfile

Reproducible demo

No response

Steps to reproduce

Click menu on mobile? 😅

Expected behavior

All links and text are visible

Actual behavior

Banner up top covers some of it

Your environment

Self-service

  • I'd be willing to fix this bug myself.
@SimenB SimenB added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Sep 28, 2022
@AnteeHub
Copy link

image

It can be reproduced on official website of Docusaurus

@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Sep 29, 2022
@slorber
Copy link
Collaborator

slorber commented Sep 29, 2022

😅 thanks, didn't catch this

Regression from #7940

temporary workaround to try:

.navbar--fixed-top {
  z-index: calc(var(--ifm-z-index-fixed) + 1);
}

@Josh-Cena Josh-Cena added the domain: theme Related to the default theme components label Sep 29, 2022
@Pranav2612000
Copy link
Contributor

@slorber
I'll like to work on this.
I tried the temporary workaround and it works. Do you want me to create a PR with it? Or do you want me to explore more and come up with a better solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution domain: theme Related to the default theme components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants