Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showLastUpdate Vietnamese translation typo #8422

Closed
2 of 7 tasks
zerot69 opened this issue Dec 9, 2022 · 3 comments · Fixed by #8424
Closed
2 of 7 tasks

showLastUpdate Vietnamese translation typo #8422

zerot69 opened this issue Dec 9, 2022 · 3 comments · Fixed by #8424
Labels
bug An error in the Docusaurus core causing instability or issues with its execution

Comments

@zerot69
Copy link

zerot69 commented Dec 9, 2022

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

When using showLastUpdateAuthor and showLastUpdateTime in Vietnamese language, there is a typo when the word "bởi" (which means "by") duplicates twice.
image
image

Reproducible demo

No response

Steps to reproduce

In your docusaurus.config.js:

i18n: {
		defaultLocale: "vi",
		locales: ["vi"],
	},
presets: [
		[
			//...
			({
				docs: {
					showLastUpdateAuthor: true,
					showLastUpdateTime: true,
				}
			}),
		],
	],

Expected behavior

It should be "Cập nhật lần cuối vào Date bởi Author"

Actual behavior

Instead of "Cập nhật lần cuối vào Date bởi bởi Author"

Your environment

  • Public source code:
  • Public site URL:
  • Docusaurus version used:
  • Environment name and version (e.g. Chrome 89, Node.js 16.4):
  • Operating system and version (e.g. Ubuntu 20.04.2 LTS):

Self-service

  • I'd be willing to fix this bug myself.
@zerot69 zerot69 added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Dec 9, 2022
@slorber slorber removed the status: needs triage This issue has not been triaged by maintainers label Dec 9, 2022
@slorber
Copy link
Collaborator

slorber commented Dec 9, 2022

Thanks, should be fixed in #8424

Can you confirm this sentence looks good?

Cập nhật lần cuối vào {date} bởi {user}

@zerot69
Copy link
Author

zerot69 commented Dec 9, 2022

@slorber that looks good 👍

@slorber
Copy link
Collaborator

slorber commented Dec 9, 2022

thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants