Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab sync using groupId not functioning #8473

Closed
6 of 7 tasks
qdot opened this issue Dec 21, 2022 · 2 comments · Fixed by #8486
Closed
6 of 7 tasks

Tab sync using groupId not functioning #8473

qdot opened this issue Dec 21, 2022 · 2 comments · Fixed by #8486
Labels
bug An error in the Docusaurus core causing instability or issues with its execution domain: theme Related to the default theme components help wanted Asking for outside help and/or contributions to this particular issue or PR.

Comments

@qdot
Copy link

qdot commented Dec 21, 2022

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of Docusaurus.
  • I have tried the npm run clear or yarn clear command.
  • I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
  • I have tried creating a repro with https://new.docusaurus.io.
  • I have read the console error message carefully (if applicable).

Description

Tab sync does not seem to work, even when Tabs blocks have a similar groupId. This issue is present across latest Firefox and Chrome, and happens within the Docusaurus documentation itself.

Reproducible demo

https://docusaurus.io/docs/markdown-features/tabs#syncing-tab-choices

Steps to reproduce

  1. Go to the docusaurus docs website, markdown-features/tabs section
  2. Try clicking the examples in the Syncing Tab Choices portion

Expected behavior

The tabs for windows/mac should change in sync.

Actual behavior

The tabs are unaffected by selections of one another.

Your environment

Self-service

  • I'd be willing to fix this bug myself.
@qdot qdot added bug An error in the Docusaurus core causing instability or issues with its execution status: needs triage This issue has not been triaged by maintainers labels Dec 21, 2022
@Josh-Cena
Copy link
Collaborator

Likely broken by #8225. Thanks for the report!

@Josh-Cena Josh-Cena added domain: theme Related to the default theme components help wanted Asking for outside help and/or contributions to this particular issue or PR. and removed status: needs triage This issue has not been triaged by maintainers labels Dec 21, 2022
@0916dhkim 0916dhkim mentioned this issue Dec 25, 2022
3 tasks
@0916dhkim
Copy link
Contributor

I opened a PR to fix this issue. Can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An error in the Docusaurus core causing instability or issues with its execution domain: theme Related to the default theme components help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
3 participants