Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Kent C. Dodds Twitter avatar #7512

Merged
merged 1 commit into from May 27, 2022
Merged

docs: update Kent C. Dodds Twitter avatar #7512

merged 1 commit into from May 27, 2022

Conversation

dharsanb
Copy link
Contributor

@dharsanb dharsanb commented May 27, 2022

Pre-flight checklist

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @dharsanb!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented May 27, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit a6cc52f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6290eff98b7579000aca28ef
😎 Deploy Preview https://deploy-preview-7512--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 83 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 80 🟢 99 🟢 100 🟢 100 🟢 90 Report

@dharsanb
Copy link
Contributor Author

@Josh-Cena, Please verify and let me know

@Josh-Cena Josh-Cena changed the title Updated Kent C. Dodds twitter image docs: update Kent C. Dodds Twitter avatar May 27, 2022
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label May 27, 2022
@Josh-Cena
Copy link
Collaborator

Change looks good—once the CLA status gets updated (provided you did sign it) we can merge 👍

@slorber
Copy link
Collaborator

slorber commented May 27, 2022

having a similar problem on my newsletter landing page 😅 wonder if there's a reliably way to get a twitter avatar URL

https://thisweekinreact.com/subscribe

@Josh-Cena
Copy link
Collaborator

Josh-Cena commented May 27, 2022

This works: https://unavatar.io/twitter/SidaChen63

I don't think there's an official API for this anymore, and no guarantees this one is future-proof

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 27, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@dharsanb
Copy link
Contributor Author

Change looks good—once the CLA status gets updated (provided you did sign it) we can merge 👍

Done @Josh-Cena

@slorber slorber merged commit 432a8bd into facebook:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kent C. Dodds Twitter avatar not displayed properly on docusaurus website
4 participants