New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(live-codeblock): add support for noInline to interactive code blocks #7514
Conversation
p.s. I've also seen the work in #6589 which would replace The given that context, is it worth me opening a separate PR to update the version of I'd love to support that upgrade however I can if that's of interest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Could you fix the build failure? We're missing an optional chaining.
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 thanks
packages/docusaurus-theme-live-codeblock/src/theme/Playground/index.tsx
Outdated
Show resolved
Hide resolved
…index.tsx Co-authored-by: Sébastien Lorber <slorber@users.noreply.github.com>
TBH I don't like the idea of introducing |
Pre-flight checklist
Motivation
These changes were prompted by several new Docusaurus-based sites that Formidable is working on.
For now we've achieved this functionality by swizzling
Playground
, but it seemed prudent to propose contributing this back upstream so others can use it too.Test Plan
Tests feel like they may not be required in this case (?) -- however I have included documentation updates which should adequately demo this functionality.
Test links
Deploy preview: https://deploy-preview-7514--docusaurus-2.netlify.app/docs/markdown-features/code-blocks/#imperative-rendering-noinline
Related issues/PRs