feat(analytics): allow query/hash changes to be sent to GA #7545
Conversation
| window.gtag('config', trackingID, { | ||
| page_path: location.pathname, | ||
| page_title: document.title, | ||
| }); |
There was a problem hiding this comment.
The config is done here so doing it again here is redundant.
There was a problem hiding this comment.
I don't really know the practice here, because here we are also sending page_path etc. Do we have docs?
There was a problem hiding this comment.
Here's the reference I used to verify. I also poked around in some internal code in our org and verified that config does not need to be ran each time. Also, near as I can tell, the page_path and page_title are ignored if passed in as a config object. config is mostly intended for handling multiple property tracker IDs, campaign IDs, etc. Its not intended as a way to log page events.
There was a problem hiding this comment.
I see—sounds good to me, then!
There was a problem hiding this comment.
This is actually like a bug fix to me and also something I suspected
When navigating, there were 2 network entries:
Now there's only one 👍
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Josh-Cena
changed the title
Josh-Cena
added
the
pr: polish
| window.gtag('config', trackingID, { | ||
| page_path: location.pathname, | ||
| page_title: document.title, | ||
| }); |
There was a problem hiding this comment.
This is actually like a bug fix to me and also something I suspected
When navigating, there were 2 network entries:
Now there's only one 👍
Pre-flight checklist
Motivation
This change will allow page transitions (i.e. changes to the query string and bookmark hash) to be sent to Google Analytics
Test Plan
Ran
yarn serve:websiteand verified that GA events are being sentRelated issues/PRs