New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(theme-translations): complete ko translations #7633
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
cc @revi @koko8829 @winterlood Could you review this please? |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Was about to select Request changes
but I seemingly lack the permission to do so.)
로딩 중 이라는 단어에 대해서는… 로딩 이라는 단어 자체가 load+ing인데 ~ing 자체가 ~중 이므로 로딩중이면 로드중중 이 되어서 비문이 되지 않나..? 싶기도 하고 관용적어구로 넘어가도 되나 싶고 애매하네요.
packages/docusaurus-theme-translations/locales/ko/plugin-ideal-image.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/ko/theme-common.json
Outdated
Show resolved
Hide resolved
Yeah, that's a bit annoying :/ Thanks for the review! |
packages/docusaurus-theme-translations/locales/ko/plugin-ideal-image.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/ko/theme-common.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/ko/theme-search-algolia.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/ko/theme-search-algolia.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/ko/plugin-ideal-image.json
Show resolved
Hide resolved
We can merge this if any of the reviewers can give a thumbs-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All reviews seem cleared now—if any of you have further ideas of improvements feel free to follow up.
@HyunseungLee-Travis Thanks for your contribution!
@revi @winterlood Thanks for the review! I've credited you both as co-authors.
Pre-flight checklist
Motivation
This PR translate some english texts still untranslated.
It also fixed some unnatural wordings.