Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-common): make useShallowMemoObject key-order-insensitive #7648

Merged
merged 1 commit into from Jun 22, 2022

Conversation

Josh-Cena
Copy link
Collaborator

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Complete a TODO.

Test Plan

Added a few more tests.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jun 20, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 20, 2022
@netlify
Copy link

netlify bot commented Jun 20, 2022

[V2]

Name Link
🔨 Latest commit e1220d1
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62afc86f8228270008e9a11e
😎 Deploy Preview https://deploy-preview-7648--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 59 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟢 90 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: +38 B (0%)

Total Size: 801 kB

Filename Size Change
website/build/assets/js/main.********.js 603 kB +38 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.6 kB
website/build/assets/css/styles.********.css 106 kB
website/build/index.html 38.9 kB

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jun 22, 2022

Thanks :D

@slorber slorber merged commit 51d7899 into main Jun 22, 2022
@slorber slorber deleted the jc/fix-type branch June 22, 2022 11:29
@slorber
Copy link
Collaborator

slorber commented Jun 22, 2022

(erf, bad main commit message)

@Josh-Cena
Copy link
Collaborator Author

Yeah, we should enable the new GH setting that always uses the PR title as message.

@slorber
Copy link
Collaborator

slorber commented Jun 22, 2022

oh didn't even know there was an option for this, will ask Paul thanks :)

CleanShot 2022-06-22 at 13 33 37@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants