Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add more info on github cross repo deployment #7677

Merged
merged 1 commit into from Jun 24, 2022

Conversation

bcabanes
Copy link
Contributor

@bcabanes bcabanes commented Jun 24, 2022

Pre-flight checklist

Motivation

Reading the guide on setting up a cross-repo deployment with Github Action is missing some key information to be successful.

This PR is adding the relevant information and the steps of the things you need to do where you have to do them.
Also changed xclip command to pbcopy which is more popular, simpler and reflects what GitHub's documentation is recommending.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 24, 2022
website/docs/deployment.mdx Outdated Show resolved Hide resolved
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 24, 2022
@netlify
Copy link

netlify bot commented Jun 24, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 62e4994
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62b5ea1cee5cae0008e4f778
😎 Deploy Preview https://deploy-preview-7677--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 69 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 87 🟢 100 🟢 100 🟢 100 🟢 90 Report

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That's much clearer.

@Josh-Cena Josh-Cena changed the title docs(core): add more info on github cross repo deployment docs: add more info on github cross repo deployment Jun 24, 2022
@netlify
Copy link

netlify bot commented Jun 24, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit b33a3aa
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62b5eb58f5dae5000836be2e
😎 Deploy Preview https://deploy-preview-7677--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Josh-Cena Josh-Cena merged commit 18b40d4 into facebook:main Jun 24, 2022
@bcabanes bcabanes deleted the docs/core/deployment branch June 24, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants