Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme-translations): Swedish translation #7715

Merged
merged 6 commits into from Jul 3, 2022
Merged

feat(theme-translations): Swedish translation #7715

merged 6 commits into from Jul 3, 2022

Conversation

johnie
Copy link
Contributor

@johnie johnie commented Jul 1, 2022 •
edited

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

This PR adds swedish translation for packages/docusaurus-theme-translations/locales/se/

Test links

Deploy preview: https://deploy-preview-7715--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 1, 2022
@netlify
Copy link

netlify bot commented Jul 1, 2022 •
edited

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 703596c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62c0477016a76a0009823f6d
😎 Deploy Preview https://deploy-preview-7715--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jul 1, 2022 •
edited

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 70 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 83 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena changed the title locales: Swedish translation feat(theme-translations): Swedish translation Jul 1, 2022
@Josh-Cena Josh-Cena added the pr: new feature This PR adds a new API or behavior. label Jul 1, 2022
Josh-Cena
Josh-Cena requested changes Jul 1, 2022
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BCP code for Swedish is sv-SE. Therefore the two-letter code should be sv.

@johnie johnie requested a review from Josh-Cena July 2, 2022 13:30
Josh-Cena
Josh-Cena approved these changes Jul 3, 2022
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM—thanks a lot for your contribution!

@Josh-Cena Josh-Cena merged commit 61f769e into facebook:main Jul 3, 2022
slorber pushed a commit that referenced this pull request Jul 14, 2022
@johnie @slorber
feat(theme-translations): Swedish translation (#7715)
a83fb26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnie @Josh-Cena @facebook-github-bot