Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme): nest theme icons under subfolder @theme/Icon/* #7740

Merged
merged 2 commits into from Jul 8, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 8, 2022

Breaking changes

All theme icons have been moved: @theme/IconXyz becomes @theme/Icon/Xyz

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Continue work of moving theme components into appropriate subfolders => better organization

Test Plan

preview works

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@slorber slorber added the pr: breaking change Existing sites may not build successfully in the new version. Description contains more details. label Jul 8, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 8, 2022
@netlify
Copy link

netlify bot commented Jul 8, 2022

[V2]

Name Link
🔨 Latest commit b03519d
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62c82db9f10c1700080a9bd8
😎 Deploy Preview https://deploy-preview-7740--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 76 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 82 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena changed the title refactor(theme): Nest theme icons under subfolder @theme/Icon/* refactor(theme): nest theme icons under subfolder @theme/Icon/* Jul 8, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Size Change: 0 B

Total Size: 804 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.6 kB
website/build/assets/css/styles.********.css 106 kB
website/build/assets/js/main.********.js 607 kB
website/build/index.html 38.9 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: breaking change Existing sites may not build successfully in the new version. Description contains more details.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants