From 308cd7ddca3966bc71a326b5dd871c82461b12e6 Mon Sep 17 00:00:00 2001 From: Yoni Chechik Date: Sun, 21 Aug 2022 14:15:25 +0300 Subject: [PATCH 1/6] Accecability problem in skip to main content `div role="region"` fixes https://github.com/facebook/docusaurus/issues/7981 --- .../docusaurus-theme-classic/src/theme/SkipToContent/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx index 0efd066e409f..a771f82b73d8 100644 --- a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx @@ -14,7 +14,7 @@ import styles from './styles.module.css'; export default function SkipToContent(): JSX.Element { const {containerRef, handleSkip} = useSkipToContent(); return ( -
+
{/* eslint-disable-next-line jsx-a11y/anchor-is-valid */} Date: Sun, 21 Aug 2022 14:23:57 +0300 Subject: [PATCH 2/6] added Translate --- .../src/theme/SkipToContent/index.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx index a771f82b73d8..fe2171b256c5 100644 --- a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx @@ -14,7 +14,11 @@ import styles from './styles.module.css'; export default function SkipToContent(): JSX.Element { const {containerRef, handleSkip} = useSkipToContent(); return ( -
+
+ Skip to main content + } {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */} Date: Sun, 21 Aug 2022 14:24:39 +0300 Subject: [PATCH 3/6] fix typo --- .../docusaurus-theme-classic/src/theme/SkipToContent/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx index fe2171b256c5..829dc7c49644 100644 --- a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx @@ -18,7 +18,7 @@ export default function SkipToContent(): JSX.Element { id="theme.common.skipToMainContentAriaLabel" description="The skip to content aria label used for accessibility of the region div "> Skip to main content - } + }> {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */} Date: Sun, 21 Aug 2022 14:49:41 +0300 Subject: [PATCH 4/6] use `translate(...)` function --- .../src/theme/SkipToContent/index.tsx | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx index 829dc7c49644..c2c733b4f594 100644 --- a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx @@ -6,7 +6,7 @@ */ import React from 'react'; -import Translate from '@docusaurus/Translate'; +import Translate, {translate} from '@docusaurus/Translate'; import {useSkipToContent} from '@docusaurus/theme-common/internal'; import styles from './styles.module.css'; @@ -14,11 +14,14 @@ import styles from './styles.module.css'; export default function SkipToContent(): JSX.Element { const {containerRef, handleSkip} = useSkipToContent(); return ( -
- Skip to main content - }> +
{/* eslint-disable-next-line jsx-a11y/anchor-is-valid */} Date: Sun, 21 Aug 2022 07:51:24 -0400 Subject: [PATCH 5/6] Update index.tsx --- .../src/theme/SkipToContent/index.tsx | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx index c2c733b4f594..21c000a5ca97 100644 --- a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx @@ -17,11 +17,7 @@ export default function SkipToContent(): JSX.Element {
+ aria-label={translate({id: 'theme.common.skipToMainContent'})}> {/* eslint-disable-next-line jsx-a11y/anchor-is-valid */} Date: Sun, 21 Aug 2022 22:20:24 +0300 Subject: [PATCH 6/6] pass prettier --- .../docusaurus-theme-classic/src/theme/SkipToContent/index.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx index 21c000a5ca97..174f813a3ae8 100644 --- a/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx +++ b/packages/docusaurus-theme-classic/src/theme/SkipToContent/index.tsx @@ -14,7 +14,7 @@ import styles from './styles.module.css'; export default function SkipToContent(): JSX.Element { const {containerRef, handleSkip} = useSkipToContent(); return ( -