Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider extracting shallowEqual. #253

Open
wtgtybhertgeghgtwtg opened this issue Jul 15, 2017 · 0 comments
Open

Consider extracting shallowEqual. #253

wtgtybhertgeghgtwtg opened this issue Jul 15, 2017 · 0 comments

Comments

@wtgtybhertgeghgtwtg
Copy link

Or using a package that does shallow equal.
Some packages (recompose, react-event-listener) end up requiring and using fbjs for the shallowEqual function, with the reasoning being that, since it's already required by react, it'd save some bits, which makes sense, but is advised against in the readme. This way, they can just use the shallow equal implementation fbjs uses instead of fbjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant