Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fbjs assumes yarn is installed but doesn't declare it as dependency #344

Open
claudiopro opened this issue Mar 29, 2019 · 2 comments
Open

Comments

@claudiopro
Copy link
Contributor

claudiopro commented Mar 29, 2019

fbjs assumes in various places yarn is installed but doesn't declare it as a dependency or call it out in the README. To name a few:

etc.

I believe it would be useful to call out fbjs depends on Facebook's omakase stack in the README at a minimum.

@zpao
Copy link
Member

zpao commented Mar 29, 2019

Ah, I totally missed that. Looks like it snuck in in #303. We should probably just fix that so it uses npm again. Or fallback to yarn. Or better, work out if you're using yarn in the caller. There's no reason for it to actually require yarn though.

That said, draft is using yarn for it's dependency manager so if you're working on draft, it should use yarn.

@zpao
Copy link
Member

zpao commented Mar 29, 2019

I don't particularly care to call it out for contributing in this project since we're fairly unfriendly to external contributions anyway (really not intended to be good at it). But we shouldn't break people trying to contribute to our projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants