getConsoleOutput receives global noStackTrace #10081
Conversation
|
@SimenB can you have a look when you are available 😃 |
| @@ -14,15 +14,16 @@ import { | |||
| import type {ConsoleBuffer} from './types'; | |||
|
|
|||
| export default ( | |||
| // TODO: remove in 26 | |||
| // TODO: remove in 27 | |||
There was a problem hiding this comment.
Missed 26, I can follow closer and create PR when 27 is near.
packages/jest-runner/src/runTest.ts
Outdated
| @@ -121,6 +121,7 @@ async function runTestInternal( | |||
| // 4 = the console call is buried 4 stack frames deep | |||
| BufferedConsole.write([], type, message, 4), | |||
| config, | |||
| globalConfig.noStackTrace, | |||
There was a problem hiding this comment.
can we pass the whole globalConfig instead?
ychi
force-pushed
the
noStackTrace-for-getConsoleOutput
branch
from
96c4714
to
ed13e4d
Compare
| config: StackTraceConfig = { | ||
| rootDir: root, | ||
| testMatch: [], | ||
| }, | ||
| globalConfig: Config.GlobalConfig, |
There was a problem hiding this comment.
Needs to be optional until next major
There was a problem hiding this comment.
I created this one and can create a PR for it, please let me know if anything is missing.
| @@ -40,12 +43,12 @@ export default ( | |||
| if (type === 'warn') { | |||
| message = chalk.yellow(message); | |||
| typeMessage = chalk.yellow(typeMessage); | |||
| noStackTrace = false; | |||
| noStackTrace = false || globalConfig.noStackTrace; | |||
There was a problem hiding this comment.
Thanks for catching! updated in a following commit.
as CLI option or config
| @@ -40,12 +44,12 @@ export default ( | |||
| if (type === 'warn') { | |||
| message = chalk.yellow(message); | |||
| typeMessage = chalk.yellow(typeMessage); | |||
| noStackTrace = false; | |||
| noStackTrace = globalConfig ? globalConfig.noStackTrace : false; | |||
There was a problem hiding this comment.
| noStackTrace = globalConfig ? globalConfig.noStackTrace : false; | |
| noStackTrace = globalConfig?.noStackTrace ?? false; |
| import {formatStackTrace} from 'jest-message-util'; | ||
| import getConsoleOutput from '../getConsoleOutput'; | ||
| import BufferedConsole from '../BufferedConsole'; | ||
| import {LogType} from '../types'; |
There was a problem hiding this comment.
| import {LogType} from '../types'; | |
| import type {LogType} from '../types'; |
| 'warn', | ||
| ]; | ||
|
|
||
| cases.forEach(logType => { |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Although
formatStackTraceacts according toStackTraceOptions,getConsoleOutputneeds to takenoStackTracevalue in global config and use it to override the options passed toformatStackTrace. This will resolve the bug mentioned hereTest plan
Pass existing test cases. Adding new test case to ensure
getConsoleOutputdoes override corresponding configuration.