feat(jest-mock): Export Mock, MockInstance, SpyInstance types #10138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilanar
force-pushed
the
export-mock-types
branch
from
918f823
to
11a4e2f
Compare
anilanar
force-pushed
the
export-mock-types
branch
from
11a4e2f
to
3b08935
Compare
sauravhiremath
pushed a commit
to MLH-Fellowship/jest
that referenced
this pull request
Jul 20, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm maintaining a utility library that eases module mocking for TS projects: https://github.com/userlike/joke
While trying to fix
@userlike/joketo be compatible with Jest 26, I've noticed that:@types/jestis not needed anymore.fnandspyOnare part of the public API, their return types are not directly exported. They can be indirectly acquired viaReturnType, but that causes loss of generic types. I see no reason why those types should not be exported as they are already part of the public contract.So I modified
jest-mockpackage to exportMock,MockInstanceandSpyInstancetypes.