feat: pretty-print web components properly #10237
Conversation
|
Hi @zaalbarxx! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
zaalbarxx
force-pushed
the
10226-pretty-print-not-handling-web-components
branch
from
58d47b7
to
fca6f68
Compare
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
zaalbarxx
force-pushed
the
10226-pretty-print-not-handling-web-components
branch
4 times, most recently
from
f942830
to
81a3d35
Compare
--added support for properly serializing/printing custom elements by pretty-print
zaalbarxx
force-pushed
the
10226-pretty-print-not-handling-web-components
branch
from
81a3d35
to
0020c13
Compare
SimenB
changed the title
|
@zaalbarxx seems this has caused a regression somehow: https://app.circleci.com/pipelines/github/storybookjs/storybook/12354/workflows/e8752f72-9082-42c5-87b3-d07ea7053a95/jobs/249451 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
--added support for properly serializing/printing custom elements by pretty-print
Summary
Previously serializing the custom elements would not be handled properly by DOMElement plugin of pretty-print and instead of element's HTML markup all of the custom element properties along with it's constructor name would be printed instead. Now custom elements will be treated in DOMElement plugin as the built-in DOM elements.
Fixes #10226
Test plan
Unit tests were written so
yarn jest DOMElement.test.ts(supports custom elementstest) will test if it's working.