Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make TestWatcher extend emittery #10324

Merged
merged 1 commit into from Dec 5, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jul 28, 2020

Summary

This gives us typed events. I'm not sure if this should be considered a breaking change or not?

Test plan

Green CI

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we vendor the typings from emittery or it's not too productive because the package is small or so? I wouldn't consider this a breaking change, because it only affects small part of TS users (watch plugins builds maybe?), and TS tend to break between minor versions.

@SimenB
Copy link
Member Author

SimenB commented Jul 28, 2020

Can we vendor the typings from emittery or it's not too productive because the package is small or so?

It'll come into the dep tree via #10227 regardless.

I wouldn't consider this a breaking change, because it only affects small part of TS users

Events are always emitted async now, not sure if it matters, tho.

No issue saving this for 27 to be on the safe side

@SimenB SimenB added this to the Jest 27 milestone Jul 28, 2020
@SimenB SimenB force-pushed the emittery-watcher branch 2 times, most recently from 40d7e1b to d4e3b4f Compare July 30, 2020 09:31
@SimenB SimenB merged commit 831139b into jestjs:master Dec 5, 2020
@SimenB SimenB deleted the emittery-watcher branch December 5, 2020 15:47
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants