Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-config): move json behind ts #10572

Merged

Conversation

jackneer
Copy link
Contributor

@jackneer jackneer commented Oct 2, 2020

As stated in #9834, I changed default file extension order by moving json behind ts and tsx. This modification preventing loading json over ts files. Please review, thanks!

Fixes #9834

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add an entry in the changelog and update the docs as well?

@SimenB SimenB added this to the Jest 27 milestone Oct 2, 2020
@facebook-github-bot
Copy link
Contributor

Hi @jackneer!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@jackneer
Copy link
Contributor Author

jackneer commented Oct 2, 2020

@SimenB Sure, I'd like to.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@SimenB
Copy link
Member

SimenB commented Oct 2, 2020

Thanks! Just updating the snapshots that CI is pointing out and this should be good to go 🙂

@jeysal
Copy link
Contributor

jeysal commented Oct 2, 2020

This is probably breaking?

@SimenB
Copy link
Member

SimenB commented Oct 2, 2020

yup, I'd say so

CHANGELOG.md Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Dec 5, 2020

@jackneer this has a few outdated snapshots - could you update them?

@SimenB SimenB changed the title move json behind ts fix(jest-config): move json behind ts Dec 22, 2020
@SimenB SimenB merged commit ec820c3 into jestjs:master Dec 22, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default moduleFileExtensions order is problematic for typescript projects
5 participants