feat: support named exports from CJS as named ESM imports #10673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
SimenB
commented
Oct 21, 2020
| let cjsExports: ReadonlyArray<string> = []; | ||
|
|
||
| if (transformedCode) { | ||
| const {exports} = parseCjs(transformedCode.code); |
There was a problem hiding this comment.
this ignore re-exports - I'm not sure what the semantics are? Where would I get the "value" from?
EDIT: I guess we could resolve the resulting path? Again, not sure what the value would be
SimenB
commented
Oct 21, 2020
| @@ -18,6 +18,8 @@ import { | |||
| Module as VMModule, | |||
| } from 'vm'; | |||
| import * as nativeModule from 'module'; | |||
| // @ts-expect-error | |||
There was a problem hiding this comment.
This was referenced Oct 26, 2020
This was referenced Mar 7, 2021
This was referenced Mar 12, 2021
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #9430 (comment)
Test plan
Test added