chore(transform): refactor API to pass an options bag around rather than multiple boolean options #10753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
force-pushed
the
transform-api-refactor
branch
4 times, most recently
from
97b1d9a
to
4ece96b
Compare
SimenB
commented
Oct 31, 2020
| @@ -260,23 +262,14 @@ export default class ScriptTransformer { | |||
| this._getTransformer(filepath); | |||
| } | |||
|
|
|||
| // TODO: replace third argument with TransformOptions in Jest 26 | |||
SimenB
commented
Oct 31, 2020
| @@ -520,9 +502,7 @@ export default class ScriptTransformer { | |||
| try { | |||
| transforming = true; | |||
| return ( | |||
| // we might wanna do `supportsDynamicImport` at some point | |||
There was a problem hiding this comment.
allowing consumers of this API to decide seems best
SimenB
force-pushed
the
transform-api-refactor
branch
from
4ece96b
to
2334d28
Compare
SimenB
commented
Oct 31, 2020
| supportsStaticESM, | ||
| } = options; | ||
| const content = stripShebang( | ||
| fileSource || fs.readFileSync(filename, 'utf8'), |
There was a problem hiding this comment.
jest-runtime already sends in the source, seemed like a good time to remove this fallback
There was a problem hiding this comment.
ugh, too painful to fix the tests, can circle back to it later. I pushed WIP stuff here: SimenB@31d67e2
SimenB
force-pushed
the
transform-api-refactor
branch
from
2334d28
to
3db82bc
Compare
|
Lovely, looking forward to this. Is it possible to have alpha/beta version to adopt earlier than waiting for official release ? |
|
Yeah, I'll be landing a whole bunch of the breaking changes we have lined up (see the milestone) next week and release an alpha |
SimenB
force-pushed
the
transform-api-refactor
branch
2 times, most recently
from
8b01868
to
e0304f9
Compare
SimenB
force-pushed
the
transform-api-refactor
branch
from
e0304f9
to
d2c8acb
Compare
…han multiple boolean options
SimenB
force-pushed
the
transform-api-refactor
branch
from
d2c8acb
to
59c2653
Compare
jeysal
added a commit
to mmkal/jest
that referenced
this pull request
Nov 8, 2020
* master: (398 commits) chore(breaking): remove undocumented `enabledTestsMap` config (jestjs#10787) Change expect.not.objectContaining() to match documentation (jestjs#10708) chore: add name to root project (jestjs#10782) Added explanation on how to use custom @jest-environment to docs (jestjs#10783) fix: remove deprecated functions from the jest object (jestjs#9853) chore: convert jest-runtime to ESM (jestjs#10325) fix(resolve): use escalade to find package.json (jestjs#10781) feat(jest-runner): set exit code to 1 if test logs after teardown (jestjs#10728) chore: add `exports` field to all `package.json`s (jestjs#9921) fix: do not inject `global` variable into module wrapper (jestjs#10644) chore: migrate jest-resolve to ESM (jestjs#10688) chore(transform): refactor API to pass an options bag around rather than multiple boolean options (jestjs#10753) chore: default to node test env rather than browser (jestjs#9874) fix: drop support for node 13 (jestjs#10685) chore: show enhanced syntax error for all syntax errors (jestjs#10749) chore: update lockfile after publish v26.6.3 chore: update changelog for release Don't throw an error if mock dependency can't be found (jestjs#10779) chore: bump babel core types (jestjs#10772) ...
|
@ahnpnl |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What it says on the tin - to make it less spaghetti to pass options internally in the class. Especially after #10752 adds 2 more fields
Test plan
Green CI