Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support index in it.each with template strings #10763

Merged
merged 4 commits into from Apr 22, 2021
Merged

Support index in it.each with template strings #10763

merged 4 commits into from Apr 22, 2021

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Nov 1, 2020

Summary

#6414 added support for indexes in jest-each using the table syntax, but not the tagged-template string version.

This PR allows $# to be used as the index/row number. I chose $# to match the $variable syntax already in use with tagged-template literals. Note that this is different to %# in the table syntax.

Test plan

The updated unit tests for template.test.ts are passing.

@facebook-github-bot
Copy link
Contributor

Hi @k-yle!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful to me, thanks! Could you also update the changelog?

@mattphillips thoughts?

@k-yle
Copy link
Contributor Author

k-yle commented Nov 1, 2020

@SimenB I've updated the changelog. No idea why tests are failing on some versions of macOS, seems unrelated to this PR? seems to be fixed now

@SimenB
Copy link
Member

SimenB commented Nov 1, 2020

All passed now 🙂 macOS is unfortunately a bit flaky

@SimenB SimenB added this to the Jest 27 milestone Feb 18, 2021
@SimenB
Copy link
Member

SimenB commented Feb 18, 2021

This looks good, let's go for it! We're currently migrating to Docusaurus 2, so holding off on landing any PRs with docs changes as porting them are painful. But will get back to it once we're ready to 🙂

@SimenB SimenB merged commit 57c3c07 into jestjs:master Apr 22, 2021
@k-yle k-yle deleted the each-index branch April 22, 2021 07:40
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants