Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no longer detecting enumerable when add domain #10862

Merged
merged 4 commits into from Nov 25, 2020
Merged

no longer detecting enumerable when add domain #10862

merged 4 commits into from Nov 25, 2020

Conversation

mapleeit
Copy link
Contributor

Summary

Considering we drop support for Node 8, this compromise can be removed.

#9136

image

Test plan

Green CI

@facebook-github-bot
Copy link
Contributor

Hi @mapleeit!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mapleeit
refactor(jest-util): no longer detecting enumerable when add domain
3787f9d 
    Considering we dropped support for Node 8, this compromise can be removed.
@thymikee thymikee requested a review from SimenB November 24, 2020 09:13
SimenB
SimenB approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a changelog entry?

@mapleeit
Copy link
Contributor Author

can you add a changelog entry?

done

@SimenB
Copy link
Member

SimenB commented Nov 25, 2020

Thanks!

@SimenB SimenB merged commit 890852b into jestjs:master Nov 25, 2020
@mapleeit mapleeit deleted the patch-1 branch November 25, 2020 09:07
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mapleeit @facebook-github-bot @SimenB @thymikee