fix: vendor node crawler from sane #10919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Dec 5, 2020
| @@ -23,6 +23,7 @@ module.exports = { | |||
| modulePathIgnorePatterns: [ | |||
| 'examples/.*', | |||
| 'packages/.*/build', | |||
| 'packages/.*/tsconfig.*', | |||
There was a problem hiding this comment.
noticed while debugging watch events
SimenB
force-pushed
the
remove-sane
branch
3 times, most recently
from
76faf90
to
d4f488c
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #10048 for motivation - tl;dr
saneis unmaintained, so we should migrate away from it.Test plan
The watcher seems to work fine locally (macOS). Should be tested more extensively, tho. Advantage here over #10048 is that it's only the node watcher that changes. Disadvantage is that we vendor all the parts of
sanewe use...