fix(workers): use advanced serialization by default in child process workers #10983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Can you see any performance differences when running the benchmark script? Should we 'keep' the default serialization for jest-hastemap? Would you mind doing a short verification if the performance did not degrade? |
MichaReiser
approved these changes
Dec 28, 2020
SimenB
force-pushed
the
advanced-serialization
branch
from
495d114
to
d384694
Compare
SimenB
force-pushed
the
advanced-serialization
branch
2 times, most recently
from
d0594fe
to
1afe39f
Compare
SimenB
force-pushed
the
advanced-serialization
branch
from
250a95d
to
cd22c47
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This introduces parity in serialization implementation between the child process and worker thread implementations.
Extracted from #10981.
Test plan
Unit test tweaked, so green CI