fix(worker): do not swallow errors when sending custom messages #10984
+22
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Dec 28, 2020
| @@ -7,31 +7,33 @@ | |||
|
|
|||
| import {PARENT_MESSAGE_CUSTOM} from '../types'; | |||
|
|
|||
| const isWorkerThread = () => { | |||
| const isWorkerThread: boolean = (() => { | |||
There was a problem hiding this comment.
only run this once instead of on each invocation of the messageParent function
SimenB
commented
Dec 28, 2020
|
|
||
| const messageParent = ( | ||
| export default function messageParent( |
There was a problem hiding this comment.
should ignore whitespace here - diff is removed try-catch and added type information
MichaReiser
approved these changes
Dec 28, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #10981.
Test plan
Error from the reproduction of #10577 changes from
to
When using
jest-circuswhich makes use of this function