fix(expect): resolve message on assertion errors
#10989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Dec 30, 2020
| @@ -293,7 +293,7 @@ const makeThrowingMatcher = ( | |||
| // Passing the result of the matcher with the error so that a custom | |||
| // reporter could access the actual and expected objects of the result | |||
| // for example in order to display a custom visual diff | |||
| error.matcherResult = result; | |||
| error.matcherResult = {...result, message}; | |||
There was a problem hiding this comment.
message is resolved to a string on line 275
thymikee
approved these changes
Dec 30, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the error is thrown from
expect, there's not reason to keep themessageproperty a function. A function is removed byJSON.stringify, so it's lost when transferred between workers. And the structured clone used byworker_threadsthrows as themessagefunction references out of scope variables.Extracted from #10981.
Test plan
Test tweaked