feat: custom haste #11107
feat: custom haste #11107
Conversation
| @@ -219,7 +229,22 @@ export default class HasteMap extends EventEmitter { | |||
| private _watchers: Array<Watcher>; | |||
| private _worker: WorkerInterface | null; | |||
|
|
|||
| constructor(options: Options) { | |||
| static getStatic(config: Config.ProjectConfig): HasteMapStatic { | |||
There was a problem hiding this comment.
can we make this async so we can use import(config.haste.hasteMapModulePath) in the future? same for create
There was a problem hiding this comment.
Changing to async complicates some call sites such as the setup function in testWorker.ts
There was a problem hiding this comment.
right, but it needs to be async in order to use ESM. so we either need to make it so now, or make it async whenever somebody wants to write these modules using ESM (such as a WASM implementation)
Codecov Report
@@ Coverage Diff @@
## master #11107 +/- ##
==========================================
- Coverage 64.20% 64.17% -0.04%
==========================================
Files 309 309
Lines 13524 13534 +10
Branches 3295 3297 +2
==========================================
+ Hits 8683 8685 +2
- Misses 4126 4134 +8
Partials 715 715
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
At Facebook, we want to use a completely custom implementation of the haste map. Overriding individual pieces such as hasteImplModulePath isn't enough to be achieve our goals with the custom implementation. We need many pieces of the build process overwritten: the crawlers, the format it is persisted to disk, and the module map. We also have added dependencies such as a sqlite library.
This change introduces the option to completely override the HasteMap class with a custom implementation. This involves relatively little changes to HasteMap itself, other than some new interfaces. The one added method is "getModuleMapFromJSON" inside HasteMap. This is needed because our custom implementation also overrides the ModuleMap serialization, so we need to go to/from serialized module maps in the correct format.
Test plan
An E2E test was written which overrides the HasteMap using this option. This custom implementation overrides all the pieces we need, including the ModuleMap. We can see with this that modules are able to be resolved with specific names as defined in the custom implementation. We can also see the custom module map serialization/deserialization working.