Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): jest should not count PerformanceObserver as an open handle #11123

Merged
merged 3 commits into from Feb 27, 2021
Merged

fix(): jest should not count PerformanceObserver as an open handle #11123

merged 3 commits into from Feb 27, 2021

Conversation

micaelmbagira
Copy link
Contributor

Fixes #11051

Summary

Test plan

@facebook-github-bot
Copy link
Contributor

Hi @micaelmbagira!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@SimenB
Copy link
Member

SimenB commented Feb 26, 2021

Thanks! Could you add a test as well?

@codecov-io
Copy link

codecov-io commented Feb 26, 2021

Codecov Report

Merging #11123 (21c6c38) into master (6150841) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11123      +/-   ##
==========================================
+ Coverage   64.06%   64.18%   +0.12%     
==========================================
  Files         307      307              
  Lines       13370    13370              
  Branches     3262     3262              
==========================================
+ Hits         8565     8582      +17     
+ Misses       4107     4083      -24     
- Partials      698      705       +7     
Impacted Files Coverage Δ
packages/jest-core/src/collectHandles.ts 41.86% <ø> (+39.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6150841...21c6c38. Read the comment docs.

@micaelmbagira
Copy link
Contributor Author

@SimenB Done, let me know if something else is missing.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@micaelmbagira
Copy link
Contributor Author

Some actions are failing but seems to be unrelated to the PR

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just left a couple of nits

CHANGELOG.md Outdated Show resolved Hide resolved
packages/jest-core/src/__tests__/collectHandles.test.js Outdated Show resolved Hide resolved
packages/jest-core/src/__tests__/collectHandles.test.js Outdated Show resolved Hide resolved
@SimenB SimenB merged commit 711b602 into jestjs:master Feb 27, 2021
@SimenB
Copy link
Member

SimenB commented Feb 27, 2021

Thanks @micaelmbagira!

@micaelmbagira micaelmbagira deleted the fix/do-not-collect-performance-observer branch February 27, 2021 14:35
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PerformanceObserver open handle
4 participants