fix: use WeakRef for tracked handles #11277
Merged
+28
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Apr 8, 2021
| @@ -37,9 +39,11 @@ function stackIsFromUser(stack: string) { | |||
|
|
|||
| const alwaysActive = () => true; | |||
|
|
|||
| const hasWeakRef = typeof WeakRef === 'function'; | |||
jeysal
reviewed
Apr 8, 2021
jeysal
reviewed
Apr 8, 2021
|
This doesn't fix issue #11275, warning still is shown and when adding the flag |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref #11275 (comment)
/cc @jasnell, would love if you could confirm it was something like this you had in mind 🙂
Test plan
Not sure... I don't see issues using this or the current approach, but if this passes CI using a WeakRef seems better as we don't wanna keep the timer from being collected if possible.