Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a language code from the link to the Node.js website #11282

Merged

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Apr 9, 2021

Summary

The current link to Node.js website on the top page links to https://nodejs.org/en/. But it should be https://nodejs.org/ so that users can visit the localized website instead of the English one.

Test plan

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit d4f7460 into jestjs:master Apr 9, 2021
@shuuji3 shuuji3 deleted the website/remove-lang-name-from-link-to-nodejs branch April 9, 2021 13:37
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants