feat: Better print for sparse arrays #11326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubzzz
changed the title
SimenB
approved these changes
Apr 22, 2021
|
Hmm, I guess this is a breaking change for people snapshotting sparse arrays... Next release is major, so no issue there, but possibly it should be marked as breaking in the changelog? |
Definitely a possible breaking. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With current version of Jest, sparse arrays are handled as any other arrays when printing them. The resulting string replaces holes by
undefined. This PR replaces the way sparse arrays are printed to show holes as holes while keeping undefined values as undefined values.Test plan
Tests have been added to check the new behaviour.