Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-each): fix placeholder interpolation #11364

Merged
merged 2 commits into from May 1, 2021

Conversation

frozenbonito
Copy link
Contributor

Summary

fix #11356
fix #11363

Test plan

Improved unit tests.

@codecov-commenter
Copy link

Codecov Report

Merging #11364 (dc8cdab) into master (26cb29a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11364      +/-   ##
==========================================
+ Coverage   64.10%   64.13%   +0.02%     
==========================================
  Files         308      308              
  Lines       13532    13535       +3     
  Branches     3297     3297              
==========================================
+ Hits         8675     8680       +5     
+ Misses       4142     4141       -1     
+ Partials      715      714       -1     
Impacted Files Coverage Δ
packages/jest-each/src/table/array.ts 100.00% <100.00%> (ø)
packages/expect/src/utils.ts 96.12% <0.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26cb29a...dc8cdab. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit e1bc733 into jestjs:master May 1, 2021
@frozenbonito frozenbonito deleted the fix-interpolation branch May 1, 2021 17:02
@github-actions
Copy link

github-actions bot commented Jun 1, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants