Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reporters): re-expose getResultHeader as a util #11460

Merged
merged 2 commits into from May 27, 2021

Conversation

FauxFaux
Copy link
Contributor

Summary

Multiple reporters, including Mozilla's famous fingers-crossed, rely on importing the getResultHeader method. As of Jest 27, ESM (correcctly) stops this deep import from working.

I believe this is a reasonable method to export, as:

  • nearly every in-built reporter, and every reporter I've used or written, seems to rely on it
  • it only deals in terms of public objects (TestResult and config), and returns a string
  • it seems to only rely on already exposed utilities, but isn't really small enough that it would be reasonable for everyone to copy-paste it into their reporters?

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me 👍

@SimenB SimenB merged commit 0088802 into jestjs:master May 27, 2021
@FauxFaux FauxFaux deleted the feat/reports-expose-resultheader branch May 27, 2021 08:36
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants