Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove jest-config dependency from jest-runner #11466

Merged
merged 7 commits into from May 28, 2021

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 27, 2021

Summary

For #9712 and a prerequisite for fixing #11465.

Test plan

Green CI

@SimenB SimenB changed the title chore: remove jest-config dependency from jest-runneer chore: remove jest-config dependency from jest-runner May 27, 2021
@SimenB SimenB requested review from jeysal and thymikee May 27, 2021 22:10
@codecov-commenter
Copy link

Codecov Report

Merging #11466 (c2ac24c) into master (0088802) will decrease coverage by 0.13%.
The diff coverage is 51.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11466      +/-   ##
==========================================
- Coverage   69.31%   69.17%   -0.14%     
==========================================
  Files         311      312       +1     
  Lines       16293    16301       +8     
  Branches     4716     4717       +1     
==========================================
- Hits        11293    11276      -17     
- Misses       4972     4997      +25     
  Partials       28       28              
Impacted Files Coverage Δ
...circus/src/legacy-code-todo-rewrite/jestAdapter.ts 0.00% <ø> (ø)
...us/src/legacy-code-todo-rewrite/jestAdapterInit.ts 0.00% <ø> (ø)
packages/jest-circus/src/testCaseReportHandler.ts 0.00% <ø> (ø)
packages/jest-config/src/index.ts 70.37% <ø> (ø)
packages/jest-config/src/utils.ts 69.56% <ø> (-11.87%) ⬇️
packages/jest-core/src/FailedTestsCache.ts 93.75% <ø> (ø)
packages/jest-core/src/ReporterDispatcher.ts 81.57% <ø> (ø)
packages/jest-core/src/SearchSource.ts 75.55% <ø> (ø)
packages/jest-core/src/TestPathPatternPrompt.ts 50.00% <ø> (ø)
packages/jest-core/src/TestScheduler.ts 80.87% <ø> (-0.11%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0088802...c2ac24c. Read the comment docs.

@SimenB SimenB merged commit 5f4dd18 into jestjs:master May 28, 2021
@SimenB SimenB deleted the remove-config-dep-from-runner branch May 28, 2021 12:14
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants