Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expect): allow expect.Matchers generic with single value #11986

Merged
merged 1 commit into from Oct 26, 2021

Conversation

mxschmitt
Copy link
Contributor

@mxschmitt mxschmitt commented Oct 22, 2021

Summary

Fixes #11985

This broke e.g. the Playwright project.

Test plan

Not sure how to provide tests for this.

@mrazauskas
Copy link
Contributor

mrazauskas commented Oct 22, 2021

Thanks. Looks like a good idea.

Most probably I can help with the test. Will take a look a bit later.

See #11985 (comment)

@mxschmitt
Copy link
Contributor Author

@mrazauskas thanks for the assistance <3

@codecov-commenter
Copy link

Codecov Report

Merging #11986 (8c0357a) into main (f41e128) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11986   +/-   ##
=======================================
  Coverage   68.74%   68.74%           
=======================================
  Files         323      323           
  Lines       16649    16649           
  Branches     4808     4808           
=======================================
  Hits        11445    11445           
  Misses       5171     5171           
  Partials       33       33           
Impacted Files Coverage Δ
packages/expect/src/index.ts 91.78% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f41e128...8c0357a. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB changed the title chore(expect): fix expect.Matchers generic with single value fix(expect): allow expect.Matchers generic with single value Oct 26, 2021
@SimenB SimenB merged commit 01c2780 into jestjs:main Oct 26, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Expect.Matchers types broke in 27.3.0
5 participants