fix: Incorrect detection of open ZLIB handles #12022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #12022 +/- ##
=======================================
Coverage 68.77% 68.77%
=======================================
Files 324 324
Lines 16669 16670 +1
Branches 4813 4814 +1
=======================================
+ Hits 11464 11465 +1
Misses 5172 5172
Partials 33 33
Continue to review full report at Codecov.
|
SimenB
approved these changes
Nov 2, 2021
It appears that some calls into `zlib` are detected as incorrectly being open. This change ignores open handles in the ZLIB context. Fixes #11542
|
Sorry for missing that. I assumed the changelog is automatically generated from git changes. I hope it's good now. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It appears that some calls into
zlibare detected as incorrectly being open. This change ignores open handles in the ZLIB context.Fixes #11542
Test plan
I added a test for this specific scenario. Before this change is applied, the test fails as expected. With this change applied, the test passes.