feat(jest-runner): allow setupFiles module to export an async function
#12042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
reviewed
Nov 5, 2021
Codecov Report
@@ Coverage Diff @@
## main #12042 +/- ##
==========================================
- Coverage 68.77% 68.72% -0.05%
==========================================
Files 324 324
Lines 16670 16682 +12
Branches 4814 4818 +4
==========================================
Hits 11465 11465
- Misses 5172 5184 +12
Partials 33 33
Continue to review full report at Codecov.
|
|
Completely lost track of this. Could you rebase @mrazauskas? |
SimenB
reviewed
Feb 24, 2022
mrazauskas
force-pushed
the
feat-async-setupFiles
branch
from
3ec5ed9
to
3ee2adf
Compare
SimenB
reviewed
Feb 25, 2022
SimenB
reviewed
Feb 25, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11038
Summary
As it is described in the issue, async function in
setupFilesmodules might be useful to fetch data asynchronously.I do not think it is the best place to set up a database, because there is no way to tear it down later without some additional script. But fetching some fixture data and temporary storing it in an object would work.
The implementation is only targeting CJS modules, because (as it was pointed out in the issue) ESM modules allow top-level await. In way this PR simply enables CJS users to have similar functionality as ESM user have.Test plan
Integration test is added.